Changeset 1035 for code/trunk/src/orxonox

Timestamp:

Apr 12, 2008, 11:23:32 PM (17 years ago)

Author:

rgrieder

Message:

• minor Singleton changes

Location:

code/trunk/src/orxonox

Files:

• GraphicsEngine.cc (modified) (1 diff)
• GraphicsEngine.h (modified) (2 diffs)
• Orxonox.cc (modified) (2 diffs)
• core/InputManager.cc (modified) (4 diffs)
• core/InputManager.h (modified) (4 diffs)
• objects/SpaceShip.cc (modified) (2 diffs)

code/trunk/src/orxonox/GraphicsEngine.cc

@@ -25 +25 @@
  *
  */
+
  /**
     @file orxonox.cc

code/trunk/src/orxonox/GraphicsEngine.h

@@ +1 @@
+/*
+ *   ORXONOX - the hottest 3D action shooter ever to exist
+ *
+ *
+ *   License notice:
+ *
+ *   This program is free software; you can redistribute it and/or
+ *   modify it under the terms of the GNU General Public License
+ *   as published by the Free Software Foundation; either version 2
+ *   of the License, or (at your option) any later version.
+ *
+ *   This program is distributed in the hope that it will be useful,
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *   GNU General Public License for more details.
+ *
+ *   You should have received a copy of the GNU General Public License
+ *   along with this program; if not, write to the Free Software
+ *   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ *
+ *   Author:
+ *      Benjamin Knecht <beni_at_orxonox.net>, (C) 2007
+ *   Co-authors:
+ *      Reto Grieder
+ *
+ */
+
 /**
-  @file GraphicsEngine.h
-  @brief Graphics Engine
+  @file
+  @brief Declaration of GraphicsEngine Singleton.
   @author Benjamin Knecht <beni_at_orxonox.net>
  */
@@ -42 +69 @@
 
       static GraphicsEngine& getSingleton();
+      static GraphicsEngine* getSingletonPtr() { return &getSingleton(); }
 
     private:
       // don't mess with singletons
       GraphicsEngine();
+      ~GraphicsEngine();
       GraphicsEngine(GraphicsEngine&) { }
-      ~GraphicsEngine();
 
       //! Method called by the LogListener from Ogre

code/trunk/src/orxonox/Orxonox.cc

@@ -113 +113 @@
       delete this->orxonoxHUD_;
     Loader::close();
-    InputManager::destroySingleton();
+    InputManager::getSingleton().destroy();
     if (this->auMan_)
       delete this->auMan_;
@@ -329 +329 @@
   void Orxonox::setupInputSystem()
   {
-    inputHandler_ = InputManager::getSingleton();
+    inputHandler_ = &InputManager::getSingleton();
     if (!inputHandler_->initialise(ogre_->getWindowHandle(),
           ogre_->getWindowWidth(), ogre_->getWindowHeight()))

code/trunk/src/orxonox/core/InputManager.cc

@@ -43 +43 @@
     @brief The reference to the singleton
   */
-  InputManager* InputManager::singletonRef_s = 0;
+  //InputManager* InputManager::singletonRef_s = 0;
 
   /**
@@ -60 +60 @@
   InputManager::~InputManager()
   {
-    this->destroyDevices();
+    this->destroy();
   }
 
   /**
     @brief The one instance of the InputManager is stored in this function.
-    @return The pointer to the only instance of the InputManager
-  */
-  InputManager *InputManager::getSingleton()
-  {
-    if (!singletonRef_s)
-      singletonRef_s = new InputManager();
-    return singletonRef_s;
+    @return A reference to the only instance of the InputManager
+  */
+  InputManager& InputManager::getSingleton()
+  {
+    static InputManager theOnlyInstance;
+    return theOnlyInstance;
   }
 
@@ -142 +141 @@
 
   /**
-    @brief Destroys all the created input devices.
-  */
-  void InputManager::destroyDevices()
-  {
-    COUT(ORX_DEBUG) << "*** InputManager: Destroying InputManager..." << std::endl;
+    @brief Destroys all the created input devices and handlers.
+  */
+  void InputManager::destroy()
+  {
+    COUT(ORX_DEBUG) << "*** InputManager: Destroying ..." << std::endl;
     if (this->mouse_)
       this->inputSystem_->destroyInputObject(mouse_);
@@ -157 +156 @@
     this->keyboard_      = 0;
     this->inputSystem_   = 0;
+
+    if (this->handlerBuffer_)
+      delete this->handlerBuffer_;
+    if (this->handlerGame_)
+      delete this->handlerGame_;
+    if (this->handlerGUI_)
+      delete this->handlerGUI_;
+
+    this->handlerBuffer_ = 0;
+    this->handlerGame_   = 0;
+    this->handlerGUI_    = 0;
+
     COUT(ORX_DEBUG) << "*** InputManager: Destroying done." << std::endl;
-  }
-
-  /**
-    @brief Destroys the singleton.
-  */
-  void InputManager::destroySingleton()
-  {
-    if (singletonRef_s)
-      delete singletonRef_s;
-    singletonRef_s = 0;
   }
 

code/trunk/src/orxonox/core/InputManager.h

@@ -67 +67 @@
   public:
     bool initialise(size_t windowHnd, int windowWidth, int windowHeight);
-    void destroyDevices();
+    void destroy();
     void tick(float dt);
     void setWindowExtents(int width, int height);
@@ -77 +77 @@
     OIS::Keyboard *getKeyboard() { return this->keyboard_; }
 
-    static InputManager* getSingleton();
-    static void destroySingleton();
+    static InputManager& getSingleton();
+    static InputManager* getSingletonPtr() { return &getSingleton(); }
 
   private:
@@ -84 +84 @@
     InputManager ();
     InputManager (const InputManager&);
-    InputManager& operator=(const InputManager& instance);
     ~InputManager();
 
@@ -99 +98 @@
 
     //! Pointer to the instance of the singleton
-    static InputManager *singletonRef_s;
+    //static InputManager *singletonRef_s;
   };
 }

code/trunk/src/orxonox/objects/SpaceShip.cc

@@ -417 +417 @@
     void SpaceShip::tick(float dt)
     {
-      if (InputManager::getSingleton()->getMouse()->getEventCallback() != this)
-        {
-            if (InputManager::getSingleton()->getMouse())
+      if (InputManager::getSingleton().getMouse()->getEventCallback() != this)
+        {
+            if (InputManager::getSingleton().getMouse())
             {
-                InputManager::getSingleton()->getMouse()->setEventCallback(this);
+                InputManager::getSingleton().getMouse()->setEventCallback(this);
                 this->setMouseEventCallback_ = true;
             }
@@ -446 +446 @@
         }
 
-        OIS::Keyboard* mKeyboard = InputManager::getSingleton()->getKeyboard();
-        OIS::Mouse* mMouse = InputManager::getSingleton()->getMouse();
+        OIS::Keyboard* mKeyboard = InputManager::getSingleton().getKeyboard();
+        OIS::Mouse* mMouse = InputManager::getSingleton().getMouse();