Changeset 10462

Timestamp:

May 24, 2015, 11:42:16 PM (10 years ago)

Author:

landauf

Message:

some refactoring in ScopeManager. made it a singleton and added functions.

Location:

code/branches/core7/src/libraries/core

Files:

• Core.cc (modified) (1 diff)
• singleton/Scope.h (modified) (5 diffs)
• singleton/ScopeManager.cc (modified) (1 diff)
• singleton/ScopeManager.h (modified) (1 diff)
• singleton/ScopedSingletonIncludes.cc (modified) (1 diff)

code/branches/core7/src/libraries/core/Core.cc

@@ -143 +143 @@
         }
 
+        // TODO: initialize ScopeManager here
         // TODO: initialize CommandLineParser here
         // TODO: initialize ConsoleCommandManager here

code/branches/core7/src/libraries/core/singleton/Scope.h

@@ -111 +111 @@
                 try
                 {
-                    ScopeManager::getInstanceCounts()[scope]++;
-                    assert(ScopeManager::getInstanceCounts()[scope] > 0);
-                    if (ScopeManager::getInstanceCounts()[scope] == 1)
+                    ScopeManager::getInstance().getInstanceCount(scope)++;
+                    assert(ScopeManager::getInstance().getInstanceCount(scope) > 0);
+                    if (ScopeManager::getInstance().getInstanceCount(scope) == 1)
                     {
                         Loki::ScopeGuard deactivator = Loki::MakeObjGuard(*this, &Scope::deactivateListeners);
-                        for (typename std::set<ScopeListener*>::iterator it = ScopeManager::getListeners()[scope].begin(); it != ScopeManager::getListeners()[scope].end(); )
+                        for (typename std::set<ScopeListener*>::iterator it = ScopeManager::getInstance().getListeners(scope).begin(); it != ScopeManager::getInstance().getListeners(scope).end(); )
                         {
                             (*it)->activated();
@@ -126 +126 @@
                 catch (...)
                 {
-                    ScopeManager::getInstanceCounts()[scope]--;
+                    ScopeManager::getInstance().getInstanceCount(scope)--;
                     throw;
                 }
@@ -138 +138 @@
                 orxout(internal_status) << "destroying scope... (" << scope << ")" << endl;
 
-                ScopeManager::getInstanceCounts()[scope]--;
+                ScopeManager::getInstance().getInstanceCount(scope)--;
 
                 // This shouldn't happen but just to be sure: check if the count is positive
-                assert(ScopeManager::getInstanceCounts()[scope] >= 0);
-                if (ScopeManager::getInstanceCounts()[scope] < 0)
-                    ScopeManager::getInstanceCounts()[scope] = 0;
+                assert(ScopeManager::getInstance().getInstanceCount(scope) >= 0);
+                if (ScopeManager::getInstance().getInstanceCount(scope) < 0)
+                    ScopeManager::getInstance().getInstanceCount(scope) = 0;
 
-                if (ScopeManager::getInstanceCounts()[scope] == 0)
+                if (ScopeManager::getInstance().getInstanceCount(scope) == 0)
                     this->deactivateListeners();
 
@@ -154 +154 @@
             void deactivateListeners()
             {
-                for (typename std::set<ScopeListener*>::iterator it = ScopeManager::getListeners()[scope].begin(); it != ScopeManager::getListeners()[scope].end(); )
+                for (typename std::set<ScopeListener*>::iterator it = ScopeManager::getInstance().getListeners(scope).begin(); it != ScopeManager::getInstance().getListeners(scope).end(); )
                 {
                     if ((*it)->bActivated_)
@@ -172 +172 @@
             static bool isActive()
             {
-                return (ScopeManager::getInstanceCounts()[scope] > 0);
+                return (ScopeManager::getInstance().getInstanceCount(scope) > 0);
             }
     };

code/branches/core7/src/libraries/core/singleton/ScopeManager.cc

@@ -32 +32 @@
 */
 
+#include "ScopeManager.h"
+
 #include "Scope.h"
 
 namespace orxonox
 {
-    /*static*/ std::map<ScopeID::Value, int>& ScopeManager::getInstanceCounts()
+    /* static */ ScopeManager& ScopeManager::getInstance()
     {
-        static std::map<ScopeID::Value, int> instanceCounts;
-        return instanceCounts;
+        static ScopeManager instance;
+        return instance;
     }
-    /*static*/ std::map<ScopeID::Value, std::set<ScopeListener*> >& ScopeManager::getListeners()
+
+    void ScopeManager::addListener(ScopeListener* listener)
     {
-        static std::map<ScopeID::Value, std::set<ScopeListener*> > listeners;
-        return listeners;
+        this->listeners_[listener->getScope()].insert(listener);
+    }
+
+    void ScopeManager::removeListener(ScopeListener* listener)
+    {
+        this->listeners_[listener->getScope()].erase(listener);
     }
 }

code/branches/core7/src/libraries/core/singleton/ScopeManager.h

@@ -54 +54 @@
     class _CoreExport ScopeManager
     {
-        template <ScopeID::Value scope>
-        friend class Scope;
-        friend class StaticallyInitializedScopedSingletonWrapper;
+        public:
+            static ScopeManager& getInstance();
+
+            void addListener(ScopeListener* listener);
+            void removeListener(ScopeListener* listener);
+
+            inline int& getInstanceCount(ScopeID::Value scope)
+                { return this->instanceCounts_[scope]; }
+            inline std::set<ScopeListener*>& getListeners(ScopeID::Value scope)
+                { return this->listeners_[scope]; }
 
         private:
-            static std::map<ScopeID::Value, int>& getInstanceCounts();                  //!< Counts the number of active instances (>0 means active) for a scope
-            static std::map<ScopeID::Value, std::set<ScopeListener*> >& getListeners(); //!< Stores all listeners for a scope
+            std::map<ScopeID::Value, int> instanceCounts_;                  //!< Counts the number of active instances (>0 means active) for a scope
+            std::map<ScopeID::Value, std::set<ScopeListener*> > listeners_; //!< Stores all listeners for a scope
     };
 }

code/branches/core7/src/libraries/core/singleton/ScopedSingletonIncludes.cc

@@ -33 +33 @@
     void StaticallyInitializedScopedSingletonWrapper::load()
     {
-        ScopeManager::getListeners()[this->wrapper_->getScope()].insert(this->wrapper_);
+        ScopeManager::getInstance().addListener(this->wrapper_);
     }
 
     void StaticallyInitializedScopedSingletonWrapper::unload()
     {
-        ScopeManager::getListeners()[this->wrapper_->getScope()].erase(this->wrapper_);
+        ScopeManager::getInstance().removeListener(this->wrapper_);
     }
 }