Changeset 10474

Timestamp:

May 25, 2015, 2:14:16 PM (10 years ago)

Author:

landauf

Message:

made NetworkFunctionManager a singleton, no static functions anymore (except for getInstance)

Location:

code/branches/core7/src

Files:

• libraries/network/FunctionCall.cc (modified) (1 diff)
• libraries/network/NetworkFunction.cc (modified) (1 diff)
• libraries/network/NetworkFunctionIncludes.h (modified) (2 diffs)
• libraries/network/NetworkFunctionManager.cc (modified) (4 diffs)
• libraries/network/NetworkFunctionManager.h (modified) (1 diff)
• libraries/network/packet/FunctionIDs.cc (modified) (2 diffs)
• orxonox/gamestates/GSRoot.cc (modified) (1 diff)

code/branches/core7/src/libraries/network/FunctionCall.cc

@@ -47 +47 @@
 
 bool FunctionCall::execute(){
-  NetworkFunctionBase* fct = static_cast<NetworkFunctionStatic*>(NetworkFunctionManager::getFunction( this->functionID_ ));
+  NetworkFunctionBase* fct = static_cast<NetworkFunctionStatic*>(NetworkFunctionManager::getInstance().getFunction( this->functionID_ ));
   assert( this->nrOfArguments_==this->arguments_.size() );
   switch(this->nrOfArguments_)

code/branches/core7/src/libraries/network/NetworkFunction.cc

@@ -38 +38 @@
 
         this->name_ = name;
-        NetworkFunctionManager::getNameMap()[name] = this;
-        NetworkFunctionManager::getFunctorMap()[p] = this;
-        NetworkFunctionManager::getIdMap()[this->getNetworkID()] = this;
+        NetworkFunctionManager::getInstance().getNameMap()[name] = this;
+        NetworkFunctionManager::getInstance().getFunctorMap()[p] = this;
+        NetworkFunctionManager::getInstance().getIdMap()[this->getNetworkID()] = this;
     }
 
     void NetworkFunctionBase::setNetworkID(uint32_t id)
     {
-        NetworkFunctionManager::getIdMap().erase(this->networkID_);  // remove old id
+        NetworkFunctionManager::getInstance().getIdMap().erase(this->networkID_);  // remove old id
         this->networkID_ = id;
-        NetworkFunctionManager::getIdMap()[this->networkID_] = this; // add new id
+        NetworkFunctionManager::getInstance().getIdMap()[this->networkID_] = this; // add new id
     }
 }

code/branches/core7/src/libraries/network/NetworkFunctionIncludes.h

@@ -51 +51 @@
             NetworkFunctionPointer p1; \
             copyPtr( functionPointer, p1 ); \
-            FunctionCallManager::addCall(NetworkFunctionManager::getFunction(p1)->getNetworkID(), OBJECTID_UNKNOWN, __VA_ARGS__); \
+            FunctionCallManager::addCall(NetworkFunctionManager::getInstance().getFunction(p1)->getNetworkID(), OBJECTID_UNKNOWN, __VA_ARGS__); \
         }
 
@@ -59 +59 @@
             NetworkFunctionPointer p1; \
             copyPtr( &class::function, p1 ); \
-            FunctionCallManager::addCall(NetworkFunctionManager::getFunction(p1)->getNetworkID(), objectID, __VA_ARGS__); \
+            FunctionCallManager::addCall(NetworkFunctionManager::getInstance().getFunction(p1)->getNetworkID(), objectID, __VA_ARGS__); \
         }
 

code/branches/core7/src/libraries/network/NetworkFunctionManager.cc

@@ -32 +32 @@
 namespace orxonox
 {
-    std::map<NetworkFunctionPointer, NetworkFunctionBase*> NetworkFunctionManager::functorMap_;
-    std::map<uint32_t, NetworkFunctionBase*> NetworkFunctionManager::idMap_;
-
     /* static */NetworkFunctionManager& NetworkFunctionManager::getInstance()
     {
@@ -41 +38 @@
     }
 
-    /*static*/void NetworkFunctionManager::setNetworkID(const std::string& name, uint32_t id)
+    void NetworkFunctionManager::setNetworkID(const std::string& name, uint32_t id)
     {
-        std::map<std::string, NetworkFunctionBase*>& map = NetworkFunctionManager::getNameMap();
+        std::map<std::string, NetworkFunctionBase*>& map = this->nameMap_;
         assert( map.find(name)!=map.end() );
         map[name]->setNetworkID(id);
     }
 
-    /*static*/void NetworkFunctionManager::destroyAllNetworkFunctions()
+    void NetworkFunctionManager::destroyAllNetworkFunctions()
     {
-        std::map<std::string, NetworkFunctionBase*>& map = NetworkFunctionManager::getNameMap();
+        std::map<std::string, NetworkFunctionBase*>& map = this->nameMap_;
         std::map<std::string, NetworkFunctionBase*>::iterator it;
         for (it = map.begin(); it != map.end(); ++it)
@@ -56 +53 @@
     }
 
-    /*static*/std::map<std::string, NetworkFunctionBase*>& NetworkFunctionManager::getNameMap()
-    {
-        static std::map<std::string, NetworkFunctionBase*> nameMap_;
-        return nameMap_;
-    }
-
-    /*static*/NetworkFunctionBase* NetworkFunctionManager::getFunction(const NetworkFunctionPointer& p)
+    NetworkFunctionBase* NetworkFunctionManager::getFunction(const NetworkFunctionPointer& p)
     {
         std::map<NetworkFunctionPointer, NetworkFunctionBase*>::iterator it = functorMap_.find(p);
@@ -69 +60 @@
     }
 
-    /*static*/NetworkFunctionBase* NetworkFunctionManager::getFunction(uint32_t id)
+    NetworkFunctionBase* NetworkFunctionManager::getFunction(uint32_t id)
     {
         std::map<uint32_t, NetworkFunctionBase*>::iterator it = idMap_.find(id);

code/branches/core7/src/libraries/network/NetworkFunctionManager.h

@@ -42 +42 @@
             static NetworkFunctionManager& getInstance();
 
-            static void setNetworkID(const std::string& name, uint32_t id);
-            static void destroyAllNetworkFunctions();
-            static std::map<std::string, NetworkFunctionBase*>& getNameMap();
+            void setNetworkID(const std::string& name, uint32_t id);
+            void destroyAllNetworkFunctions();
 
-            static inline std::map<NetworkFunctionPointer, NetworkFunctionBase*>& getFunctorMap()
+            inline std::map<std::string, NetworkFunctionBase*>& getNameMap()
+                { return nameMap_; }
+            inline std::map<NetworkFunctionPointer, NetworkFunctionBase*>& getFunctorMap()
                 { return functorMap_; }
-            static inline std::map<uint32_t, NetworkFunctionBase*>& getIdMap()
+            inline std::map<uint32_t, NetworkFunctionBase*>& getIdMap()
                 { return idMap_; }
 
-            static NetworkFunctionBase* getFunction(const NetworkFunctionPointer& p);
-            static NetworkFunctionBase* getFunction(uint32_t id);
+            NetworkFunctionBase* getFunction(const NetworkFunctionPointer& p);
+            NetworkFunctionBase* getFunction(uint32_t id);
 
         private:
-            static std::map<NetworkFunctionPointer, NetworkFunctionBase*> functorMap_;
-            static std::map<uint32_t, NetworkFunctionBase*> idMap_;
+            std::map<std::string, NetworkFunctionBase*> nameMap_;
+            std::map<NetworkFunctionPointer, NetworkFunctionBase*> functorMap_;
+            std::map<uint32_t, NetworkFunctionBase*> idMap_;
     };
 }

code/branches/core7/src/libraries/network/packet/FunctionIDs.cc

@@ -56 +56 @@
 
   //calculate total needed size (for all strings and integers)
-  std::map<std::string, NetworkFunctionBase*>& map = NetworkFunctionManager::getNameMap();
+  std::map<std::string, NetworkFunctionBase*>& map = NetworkFunctionManager::getInstance().getNameMap();
   std::map<std::string, NetworkFunctionBase*>::iterator it;
   for (it = map.begin(); it != map.end(); ++it)
@@ -140 +140 @@
     functionname = temp+2*sizeof(uint32_t);
     orxout(internal_info, context::packets) << "processing functionid: " << networkID << " name: " << functionname << endl;
-    NetworkFunctionManager::setNetworkID((const char*)functionname, networkID);
+    NetworkFunctionManager::getInstance().setNetworkID((const char*)functionname, networkID);
     temp += 2*sizeof(uint32_t) + stringsize;
   }

code/branches/core7/src/orxonox/gamestates/GSRoot.cc

@@ -69 +69 @@
     GSRoot::~GSRoot()
     {
-        NetworkFunctionManager::destroyAllNetworkFunctions();
+        NetworkFunctionManager::getInstance().destroyAllNetworkFunctions();
     }