Changeset 10817 for code/branches/cpp11_v2/src/libraries/core/object

Timestamp:

Nov 19, 2015, 11:40:28 AM (9 years ago)

Author:

muemart

Message:

Run clang-modernize -add-override
A few notes:

• There are probably some overrides missing, especially in funky templatey code
• Virtual methods with wrong signatures were not fixed, needs to be done by hand (only warnings get emitted)

Location:

code/branches/cpp11_v2/src/libraries/core/object

Files:

• DestroyLaterManager.h (modified) (1 diff)
• IteratorBase.h (modified) (1 diff)
• ObjectListBase.h (modified) (1 diff)
• WeakPtr.h (modified) (1 diff)

code/branches/cpp11_v2/src/libraries/core/object/DestroyLaterManager.h

@@ -45 +45 @@
             virtual ~DestroyLaterManager();
 
-            virtual void preUpdate(const Clock& time) { /*no action*/ }
-            virtual void postUpdate(const Clock& time);
+            virtual void preUpdate(const Clock& time) override { /*no action*/ }
+            virtual void postUpdate(const Clock& time) override;
 
             void retain(Destroyable* instance)

code/branches/cpp11_v2/src/libraries/core/object/IteratorBase.h

@@ -175 +175 @@
                 @param object The object to compare with
             */
-            virtual void removedElement(ObjectListBaseElement* element)
+            virtual void removedElement(ObjectListBaseElement* element) override
             {
                 if (this->element_ == element)

code/branches/cpp11_v2/src/libraries/core/object/ObjectListBase.h

@@ -82 +82 @@
             ObjectListElement(T* object) : ObjectListBaseElement(static_cast<Listable*>(object)), object_(object) {}
 
-            virtual void changeContext(Context* oldContext, Context* newContext)
+            virtual void changeContext(Context* oldContext, Context* newContext) override
             {
                 // add object to new context, but only if this element belongs exactly to the old context (and not to a sub-context to avoid re-adding objects

code/branches/cpp11_v2/src/libraries/core/object/WeakPtr.h

@@ -230 +230 @@
         private:
             /// Will be called by Destroyable::~Destroyable() if the stored object is deleted. Resets the wrapped pointer and executes the callback.
-            inline void objectDeleted()
+            inline void objectDeleted() override
             {
                 this->base_ = nullptr;