Changeset 10817 for code/branches/cpp11_v2/src/libraries/network/packet

Timestamp:

Nov 19, 2015, 11:40:28 AM (9 years ago)

Author:

muemart

Message:

Run clang-modernize -add-override
A few notes:

• There are probably some overrides missing, especially in funky templatey code
• Virtual methods with wrong signatures were not fixed, needs to be done by hand (only warnings get emitted)

Location:

code/branches/cpp11_v2/src/libraries/network/packet

Files:

• Acknowledgement.h (modified) (1 diff)
• Chat.h (modified) (1 diff)
• ClassID.h (modified) (1 diff)
• DeleteObjects.h (modified) (1 diff)
• FunctionCalls.h (modified) (1 diff)
• FunctionIDs.h (modified) (1 diff)
• Gamestate.h (modified) (1 diff)
• Welcome.h (modified) (1 diff)

code/branches/cpp11_v2/src/libraries/network/packet/Acknowledgement.h

@@ -46 +46 @@
   ~Acknowledgement();
 
-  inline unsigned int getSize() const;
-  virtual bool process(orxonox::Host* host);
+  inline unsigned int getSize() const override;
+  virtual bool process(orxonox::Host* host) override;
 
   unsigned int getAckID();

code/branches/cpp11_v2/src/libraries/network/packet/Chat.h

@@ -49 +49 @@
 
   /* get size of packet */
-  inline unsigned int getSize() const;
+  inline unsigned int getSize() const override;
 
   /* process chat message packet and remove it afterwards */
-  virtual bool process(orxonox::Host* host);
+  virtual bool process(orxonox::Host* host) override;
 
   /* Get the length of the message (not the full size of the packet) */

code/branches/cpp11_v2/src/libraries/network/packet/ClassID.h

@@ -47 +47 @@
   ~ClassID();
 
-  uint32_t getSize() const;
-  virtual bool process(orxonox::Host* host);
+  uint32_t getSize() const override;
+  virtual bool process(orxonox::Host* host) override;
 
 private:

code/branches/cpp11_v2/src/libraries/network/packet/DeleteObjects.h

@@ -48 +48 @@
   bool fetchIDs();
 
-  inline unsigned int getSize() const;
-  virtual bool process(orxonox::Host* host);
+  inline unsigned int getSize() const override;
+  virtual bool process(orxonox::Host* host) override;
 
 private:

code/branches/cpp11_v2/src/libraries/network/packet/FunctionCalls.h

@@ -52 +52 @@
   ~FunctionCalls();
 
-  inline unsigned int getSize() const
+  inline unsigned int getSize() const override
     { assert(!this->isDataENetAllocated()); return currentSize_; }
-  virtual bool process(orxonox::Host* host);
+  virtual bool process(orxonox::Host* host) override;
 
   void addCall( uint32_t networkID, uint32_t objectID, const MultiType& mt1, const MultiType& mt2, const MultiType& mt3, const MultiType& mt4, const MultiType& mt5);
-  virtual bool send(orxonox::Host* host);
+  virtual bool send(orxonox::Host* host) override;
 private:
   std::queue<orxonox::FunctionCall> functionCalls_;

code/branches/cpp11_v2/src/libraries/network/packet/FunctionIDs.h

@@ -47 +47 @@
   ~FunctionIDs();
 
-  virtual uint32_t getSize() const;
-  virtual bool process(orxonox::Host* host);
+  virtual uint32_t getSize() const override;
+  virtual bool process(orxonox::Host* host) override;
 
 private:

code/branches/cpp11_v2/src/libraries/network/packet/Gamestate.h

@@ -138 +138 @@
 //     void rawDiff( uint8_t* newdata, uint8_t* data, uint8_t* basedata, uint32_t datalength, uint32_t baselength);
 //     inline uint32_t findObject( const SynchronisableHeader& header, uint8_t* mem, uint32_t dataLength, uint32_t startPosition = 0 );
-    virtual uint32_t getSize() const;
-    virtual bool process(orxonox::Host* host);
+    virtual uint32_t getSize() const override;
+    virtual bool process(orxonox::Host* host) override;
     uint32_t calcGamestateSize(uint32_t id, uint8_t mode=0x0);
 //     inline void diffObject( uint8_t*& newData, uint8_t*& origData, uint8_t*& baseData, SynchronisableHeader& objectHeader, std::vector<uint32_t>::iterator& sizes );

code/branches/cpp11_v2/src/libraries/network/packet/Welcome.h

@@ -45 +45 @@
   virtual ~Welcome();
 
-  uint8_t *getData();
-  inline unsigned int getSize() const;
-  virtual bool process(orxonox::Host* host);
+  uint8_t *getData() override;
+  inline unsigned int getSize() const override;
+  virtual bool process(orxonox::Host* host) override;
 
 private: