Changeset 10817 for code/branches/cpp11_v2/src/orxonox/sound

Timestamp:

Nov 19, 2015, 11:40:28 AM (10 years ago)

Author:

muemart

Message:

Run clang-modernize -add-override
A few notes:

• There are probably some overrides missing, especially in funky templatey code
• Virtual methods with wrong signatures were not fixed, needs to be done by hand (only warnings get emitted)

Location:

code/branches/cpp11_v2/src/orxonox/sound

Files:

• AmbientSound.h (modified) (2 diffs)
• SoundManager.h (modified) (1 diff)
• WorldAmbientSound.h (modified) (1 diff)
• WorldSound.h (modified) (2 diffs)

code/branches/cpp11_v2/src/orxonox/sound/AmbientSound.h

@@ -50 +50 @@
         AmbientSound();
 
-        void play();
-        bool stop();
-        void pause();
+        void play() override;
+        bool stop() override;
+        void pause() override;
 
         bool setAmbientSource(const std::string& source);
@@ -66 +66 @@
 
     private:
-        void preDestroy();
-        float getRealVolume();
-        bool moodChanged(const std::string& mood);
+        void preDestroy() override;
+        float getRealVolume() override;
+        bool moodChanged(const std::string& mood) override;
         inline void ambientSourceChanged()
             { this->setAmbientSource(this->ambientSource_); }

code/branches/cpp11_v2/src/orxonox/sound/SoundManager.h

@@ -68 +68 @@
         ~SoundManager();
 
-        void preUpdate(const Clock& time);
-        void postUpdate(const Clock& time) { /*no action*/ }
+        void preUpdate(const Clock& time) override;
+        void postUpdate(const Clock& time) override { /*no action*/ }
         void setConfigValues();
 

code/branches/cpp11_v2/src/orxonox/sound/WorldAmbientSound.h

@@ -50 +50 @@
             virtual ~WorldAmbientSound();
 
-            void XMLPort(Element& xmlelement, XMLPort::Mode mode);
-            void XMLEventPort(Element& xmlelement, XMLPort::Mode mode);
+            void XMLPort(Element& xmlelement, XMLPort::Mode mode) override;
+            void XMLEventPort(Element& xmlelement, XMLPort::Mode mode) override;
 
-            virtual void changedActivity();
+            virtual void changedActivity() override;
 
             void play();

code/branches/cpp11_v2/src/orxonox/sound/WorldSound.h

@@ -47 +47 @@
         WorldSound(Context* context);
 
-        void XMLPort(Element& xmlelement, XMLPort::Mode mode);
-        void XMLEventPort(Element& xmlelement, XMLPort::Mode mode);
-        void changedActivity();
+        void XMLPort(Element& xmlelement, XMLPort::Mode mode) override;
+        void XMLEventPort(Element& xmlelement, XMLPort::Mode mode) override;
+        void changedActivity() override;
 
-        void tick(float dt);
+        void tick(float dt) override;
 
     protected:
@@ -58 +58 @@
     private:
         void registerVariables();
-        void initialiseSource();
-        float getRealVolume();
+        void initialiseSource() override;
+        float getRealVolume() override;
     };
 }