Changeset 11715 for code/trunk/src/orxonox

Timestamp:

Jan 7, 2018, 9:16:52 PM (7 years ago)

Author:

landauf

Message:

[Highscore_HS16] removed playerName from Highscore because the player already has a name (see HumanPlayer.nick)

Location:

code/trunk/src/orxonox

Files:

• Highscore.cc (modified) (5 diffs)
• Highscore.h (modified) (2 diffs)

code/trunk/src/orxonox/Highscore.cc

@@ -1 +1 @@
 #include "Highscore.h"
 
-#include <vector>
 #include "core/CoreIncludes.h"
 #include "core/config/ConfigValueIncludes.h"
 #include "core/singleton/ScopedSingletonIncludes.h"
+#include "infos/PlayerInfo.h"
+#include "util/Convert.h"
 
 namespace orxonox
 {
-
     ManageScopedSingleton(Highscore, ScopeID::ROOT, false);
         RegisterClassNoArgs(Highscore);
@@ -17 +17 @@
         this->setConfigValues();
     }
+
     /**
      * @brief set the config values in the orxonox.ini file
@@ -23 +24 @@
     {
         SetConfigValue(highscores_, std::vector<std::string>()).description("Highscores saved as vector");
-        SetConfigValue(playerName_, "Player").description("Name of the player");
     }
+
     /**
      * @brief Returns highest score of given game, if exists.
      * Else returns -1.
      */
-    int Highscore::getHighestScoreOfGame(std::string game){
-        std::string delimiter = "./."; //score save as "Playername./.game./.score"
+    int Highscore::getHighestScoreOfGame(const std::string& game){
+        const std::string delimiter = "./."; //score save as "Playername./.game./.score"
         int best = -1;
         //check for the highest Score of given game
@@ -39 +40 @@
             if(game.compare(score.substr(0,score.find(delimiter))) == 0){
                 score.erase(0, score.find(delimiter) + delimiter.length());
-                int possibleBest = std::stoi(score);
+                int possibleBest = multi_cast<int>(score);
                 if(possibleBest > best) best = possibleBest;
             }
-
-
         }
         
@@ -49 +48 @@
         
     }
+
     /**
      * @brief stores a new highscore in the orxonox.ini file
      */
-    void Highscore::storeHighscore(std::string level, int points){
-        ModifyConfigValue(highscores_, add, playerName_+"./."+level+"./."+std::to_string(points));
+    void Highscore::storeHighscore(const std::string& level, int points, PlayerInfo* player){
+        ModifyConfigValue(highscores_, add, player->getName() + "./." + level + "./." + multi_cast<std::string>(points));
     }
-    
 }

code/trunk/src/orxonox/Highscore.h

@@ -1 +1 @@
 #include <string>
+#include <vector>
+
+#include "OrxonoxPrereqs.h"
 #include "core/config/Configurable.h"
-#include "OrxonoxPrereqs.h"
 #include "util/Singleton.h"
+
 // tolua_begin
 namespace orxonox
@@ -14 +17 @@
         Highscore();              // Constructor
         void setConfigValues(); // Inherited function
-        void storeHighscore(std::string level, int points);
 
-        int getHighestScoreOfGame(std::string game);
+        void storeHighscore(const std::string& level, int points, PlayerInfo* player);
+        int getHighestScoreOfGame(const std::string& game);
+
         // tolua_begin
         inline unsigned int getNumberOfHighscores()
-                { return this->highscores_.size(); }
-            inline const std::string& getHighscore(unsigned int index)
-                { return this->highscores_[index]; }
+            { return this->highscores_.size(); }
+        inline const std::string& getHighscore(unsigned int index)
+            { return this->highscores_[index]; }
 
         static Highscore& getInstance()
-                { return Singleton<Highscore>::getInstance(); }
-
+            { return Singleton<Highscore>::getInstance(); }
         // tolua_end 
-
 
     private:
         std::vector<std::string> highscores_;
-        float version_;
-        std::string playerName_;
         static Highscore* singletonPtr_s;
 }; //tolua_export