Changeset 11729

Timestamp:

Feb 11, 2018, 4:49:56 PM (7 years ago)

Author:

landauf

Message:

fixed crash when setting highscore

Location:

code/branches/Presentation_HS17_merge/src/modules

Files:

• asteroids2D/Asteroids2D.cc (modified) (6 diffs)
• asteroids2D/Asteroids2D.h (modified) (1 diff)
• asteroids2D/Asteroids2DStone.h (modified) (2 diffs)
• dodgerace/DodgeRace.cc (modified) (6 diffs)
• dodgerace/DodgeRace.h (modified) (1 diff)

code/branches/Presentation_HS17_merge/src/modules/asteroids2D/Asteroids2D.cc

@@ -59 +59 @@
 #include "Highscore.h"
 #include "gamestates/GSLevel.h"
+#include "infos/PlayerInfo.h"
 
 namespace orxonox
@@ -124 +125 @@
         if(this->firstTick_)
         {
-            getPlayer();
             for(int i = 0; i < 5; ++i)
             {
@@ -141 +141 @@
         //stones are created with a size -> second constructor in Asteroids2DStone class
         Asteroids2DStone* newStone = new Asteroids2DStone(this->center_->getContext());
-        newStone->setAsteroids2DPlayer(player);
 
         //look at templates in data/levels/templates/asteroidsAsteroids2D.oxt
@@ -163 +162 @@
     Asteroids2DShip* Asteroids2D::getPlayer()
     {
-        if (player == nullptr)
-        {
-            for (Asteroids2DShip* ship : ObjectList<Asteroids2DShip>())
-            {
-                player = ship;
-            }
-        }
-        return player;
+        for (Asteroids2DShip* ship : ObjectList<Asteroids2DShip>())
+        {
+            return ship;
+        }
+        return nullptr;
     }
 
@@ -201 +197 @@
     void Asteroids2D::playerPreSpawn(PlayerInfo* player)
     {
+        this->playerInfo_ = player;
         if(lives <= 0)
         {
@@ -226 +223 @@
         {
             int score = this->getPoints();
-            Highscore::getInstance().storeScore("Asteroids2D", score, this->getPlayer()->getPlayer());
+            Highscore::getInstance().storeScore("Asteroids2D", score, this->playerInfo_);
         }
         GSLevel::startMainMenu();

code/branches/Presentation_HS17_merge/src/modules/asteroids2D/Asteroids2D.h

@@ -94 +94 @@
 
 
-            WeakPtr<Asteroids2DShip> player;
+            WeakPtr<PlayerInfo> playerInfo_;
             void toggleShowLevel(){bShowLevel = !bShowLevel;}
 

code/branches/Presentation_HS17_merge/src/modules/asteroids2D/Asteroids2DStone.h

@@ -53 +53 @@
             Vector3 randomPosition (float maxwidth, float maxheight);
             Vector3 randomVelocity(float maxspeed);
-            void setAsteroids2DPlayer(Asteroids2DShip* player){this->player = player;};
             virtual int getSize(){ return this->size;}
             virtual bool collidesAgainst(WorldEntity* otherObject, const btCollisionShape* ownCollisionShape, btManifoldPoint& contactPoint) override;
@@ -62 +61 @@
           Asteroids2D* getGame();
           WeakPtr<Asteroids2D> game;
-          WeakPtr<Asteroids2DShip> player;          
                 int size;                               // three sizes, 3-> two 2s, 2-> two 1s, 1-> die
                 float width, height;    //field

code/branches/Presentation_HS17_merge/src/modules/dodgerace/DodgeRace.cc

@@ -37 +37 @@
 #include "core/CoreIncludes.h"
 #include "Highscore.h"
+#include "infos/PlayerInfo.h"
 
 namespace orxonox
@@ -90 +91 @@
     void DodgeRace::tick(float dt)
     {
-        if (getPlayer() != nullptr)
-        {
-            currentPosition = getPlayer()->getWorldPosition().x;
+        DodgeRaceShip* player = this->getPlayer();
+        if (player != nullptr)
+        {
+            currentPosition = player->getWorldPosition().x;
             counter = counter + (currentPosition - lastPosition);
             lastPosition = currentPosition;
             point = (int) currentPosition;
-            getPlayer()->speed = 830.0f - (point / 1000);
+            player->speed = 830.0f - (point / 1000);
 
             for(unsigned int i=0; i < cubeList.size();i++)
@@ -123 +125 @@
                     }
 
-                    cube->setPosition(getPlayer()->getWorldPosition() + Vector3(5000.0f, 0.0f, -3600.0f + (i*1200)));
+                    cube->setPosition(player->getWorldPosition() + Vector3(5000.0f, 0.0f, -3600.0f + (i*1200)));
                     //stEntity->setScale3D(50,50,50);
                 }
@@ -139 +141 @@
     DodgeRaceShip* DodgeRace::getPlayer()
     {
-        if (player == nullptr)
-        {
-            for (DodgeRaceShip* ship : ObjectList<DodgeRaceShip>())
-            {
-                player = ship;
-            }
-        }
-        return player;
+        for (DodgeRaceShip* ship : ObjectList<DodgeRaceShip>())
+        {
+            return ship;
+        }
+        return nullptr;
     }
 
@@ -190 +189 @@
     void DodgeRace::playerPreSpawn(PlayerInfo* player)
     {
+        this->playerInfo_ = player;
         if(lives <= 0)
         {
@@ -228 +228 @@
         {
             int score = this->getPoints();
-            Highscore::getInstance().storeScore("Dodge Race", score, this->getPlayer()->getPlayer());
+            Highscore::getInstance().storeScore("Dodge Race", score, this->playerInfo_);
         }
         GSLevel::startMainMenu();

code/branches/Presentation_HS17_merge/src/modules/dodgerace/DodgeRace.h

@@ -103 +103 @@
 
             DodgeRaceShip* getPlayer();
-            WeakPtr<DodgeRaceShip> player;
+            WeakPtr<PlayerInfo> playerInfo_;
             std::vector<DodgeRaceCube*> cubeList;
             void toggleShowLevel(){bShowLevel = !bShowLevel;}