Changeset 1245 for code/branches/network3/src/network

Timestamp:

May 7, 2008, 4:39:42 PM (17 years ago)

Author:

scheusso

Message:

different enhancements in input/network handling and synchronisation

Location:

code/branches/network3/src/network

Files:

• Client.cc (modified) (6 diffs)
• Client.h (modified) (2 diffs)
• ClientConnection.h (modified) (1 diff)
• ConnectionManager.cc (modified) (7 diffs)
• ConnectionManager.h (modified) (1 diff)
• GameStateClient.cc (modified) (3 diffs)
• GameStateClient.h (modified) (1 diff)
• GameStateManager.cc (modified) (7 diffs)
• PacketDecoder.cc (modified) (4 diffs)
• PacketManager.h (modified) (2 diffs)
• Server.cc (modified) (2 diffs)
• Server.h (modified) (1 diff)
• Synchronisable.cc (modified) (3 diffs)

code/branches/network3/src/network/Client.cc

@@ -84 +84 @@
     // set server address to localhost
     isConnected=false;
+    test_once=false;
   }
 
@@ -93 +94 @@
   Client::Client(std::string address, int port) : client_connection(port, address){
     isConnected=false;
+    test_once=false;
   }
 
@@ -102 +104 @@
   Client::Client(const char *address, int port) : client_connection(port, address){
     isConnected=false;
+    test_once=false;
   }
 
@@ -226 +229 @@
   */
   void Client::tick(float time){
+    if(client_connection.isConnected()){
+      COUT(4) << "popping partial gamestate: " << std::endl;
+      GameStateCompressed *gs = gamestate.popPartialGameState();
+      if(gs){
+        COUT(4) << "client tick: sending gs " << gs << std::endl;
+        if(client_connection.addPacket(pck_gen.gstate(gs)))
+          if(!client_connection.sendPackets())
+            COUT(3) << "Problem sending partial gamestate" << std::endl;
+        // now delete it to save memory
+        delete [] gs->data;
+        delete gs;
+      }
+    }
     ENetPacket *packet;
     // stop if the packet queue is empty
@@ -231 +247 @@
       packet = client_connection.getPacket();
       COUT(5) << "tick packet size " << packet->dataLength << std::endl;
-      elaborate(packet, 0); // ================= i guess we got to change this .... (client_ID is always same = server)
+      if(!test_once){
+        elaborate(packet, 0); // ================= i guess we got to change this .... (client_ID is always same = server)
+      }
     }
     return;
   }
 
-  void Client::processGamestate( GameStateCompressed *data){
-    int id = data->id;
-    COUT(5) << "received gamestate id: " << data->id << std::endl;
-    if(gamestate.pushGameState(data)){
-      client_connection.addPacket(pck_gen.acknowledgement(id));
-      if(!client_connection.sendPackets())
-        COUT(2) << "Could not send acknowledgment" << std::endl;
+  void Client::processGamestate( GameStateCompressed *data, int clientID){
+    if(!test_once){
+      int id = data->id;
+      COUT(5) << "received gamestate id: " << data->id << std::endl;
+      if(gamestate.pushGameState(data)){
+        client_connection.addPacket(pck_gen.acknowledgement(id));
+        if(!client_connection.sendPackets())
+          COUT(2) << "Could not send acknowledgment" << std::endl;
+      }
+//       test_once=true;
     }
   }
@@ -263 +284 @@
     clientID_ = w->clientID;
     shipID_ = w->shipID;
-    
+    return true;
   }
 

code/branches/network3/src/network/Client.h

@@ -103 +103 @@
 
     // implement data processing functions of PacketDecoder
-    void processGamestate( GameStateCompressed *data);
+    void processGamestate( GameStateCompressed *data, int clientID);
     void processClassid(classid *clid);
     void processChat( chat *data);
@@ -109 +109 @@
     int clientID_;     // this is the id the server gave to us
     int shipID_;
+    bool test_once;
   };
 

code/branches/network3/src/network/ClientConnection.h

@@ -76 +76 @@
     bool sendPackets(ENetEvent *event);
     bool waitEstablished(int milisec);
+    bool isConnected(){return established;}
   private:
     bool processData(ENetEvent *event);

code/branches/network3/src/network/ConnectionManager.cc

@@ -165 +165 @@
     enet_initialize();
     atexit(enet_deinitialize);
-    ENetEvent event;
+    ENetEvent *event = new ENetEvent;
     server = enet_host_create(&bindAddress, NETWORK_MAX_CONNECTIONS, 0, 0);
     if(server==NULL){
@@ -174 +174 @@
 
     while(!quit){
-      if(enet_host_service(server, &event, NETWORK_WAIT_TIMEOUT)<0){
+      if(enet_host_service(server, event, NETWORK_WAIT_TIMEOUT)<0){
         // we should never reach this point
         quit=true;
         // add some error handling here ========================
       }
-      switch(event.type){
+      switch(event->type){
         // log handling ================
         case ENET_EVENT_TYPE_CONNECT:
-          addClient(&event);
+          addClient(event);
           //this is a workaround to ensure thread safety
           /*if(!addFakeConnectRequest(&event))
@@ -191 +191 @@
           //std::cout << "received data" << std::endl;
           COUT(5) << "Con.Man: receive event has occured" << std::endl;
-          processData(&event);
+          processData(event);
           break;
         case ENET_EVENT_TYPE_DISCONNECT:
-          // add some error/log handling here
-          clientDisconnect(event.peer);
+          clientDisconnect(event->peer);
           break;
         case ENET_EVENT_TYPE_NONE:
           break;
       }
+//       usleep(1000);
+      //yield(); //TODO: find apropriate
     }
     disconnectClients();
@@ -246 +247 @@
   bool ConnectionManager::clientDisconnect(ENetPeer *peer) {
     COUT(4) << "removing client from list" << std::endl;
-    return head_->removeClient(peer);
+    return removeClient(head_->findClient(&(peer->address))->getID());
   }
 /**
@@ -311 +312 @@
     sendWelcome(temp->getID(), temp->getShipID(), true);
     return true;
+  }
+  
+  bool ConnectionManager::removeClient(int clientID){
+    orxonox::Iterator<orxonox::SpaceShip> it = orxonox::ObjectList<orxonox::SpaceShip>::start();
+    while(it){
+      if(it->objectID!=head_->findClient(clientID)->getShipID()){
+        ++it;
+        continue;
+      }
+      orxonox::Iterator<orxonox::SpaceShip> temp=it;
+      ++it;
+      delete  *temp;
+      return head_->removeClient(clientID);
+    }
+    return false;
   }
   
@@ -335 +351 @@
     
     client->setShipID(no->objectID);
-    no->getFocus();
     return true;
   }
@@ -342 +357 @@
     addPacket(packet_gen.generateWelcome(clientID, shipID, allowed),clientID);
     sendPackets();
+    return true;
   }
   

code/branches/network3/src/network/ConnectionManager.h

@@ -89 +89 @@
   private:
     bool clientDisconnect(ENetPeer *peer);
+    bool removeClient(int clientID);
     bool processData(ENetEvent *event);
     bool addClient(ENetEvent *event);

code/branches/network3/src/network/GameStateClient.cc

@@ -166 +166 @@
 
   GameState *GameStateClient::getPartialSnapshot(){
+    
+    GameState *reference;
+//     std::map<int, GameState*>::iterator it = --gameStateMap.end();
+//     reference=(--gameStateMap.end())->second;
+    
     //std::cout << "begin getSnapshot" << std::endl;
     //the size of the gamestate
@@ -178 +183 @@
 
     GameState *retval=new GameState; //return value
-    retval->id=reference->id;
+//     retval->id=reference->id;
+    if(gameStateMap.size()!=0)
+      retval->id=(--gameStateMap.end())->second->id;
     retval->diffed=false;
     retval->complete=false;
@@ -190 +197 @@
       size+=it->getSize(); // size of the actual data of the synchronisable
       size+=3*sizeof(int); // size of datasize, classID and objectID
+      COUT(4) << "getpartialsnapshot: size: " << size << std::endl;
     }
     //retval->data = (unsigned char*)malloc(size);

code/branches/network3/src/network/GameStateClient.h

@@ -70 +70 @@
     void printGameStateMap();
 
-    GameState     *reference;
     int           last_diff_;
     std::map<int, GameState *> gameStateMap;

code/branches/network3/src/network/GameStateManager.cc

@@ -106 +106 @@
     if(gID != GAMESTATEID_INITIAL){
       // TODO something with the gamestatemap is wrong
-      GameState *client = gameStateMap.find(gID)->second;
+      GameState *client=NULL;
+      std::map<int, GameState*>::iterator it = gameStateMap.find(gID);
+      if(it!=gameStateMap.end())
+        client = it->second;
       GameState *server = reference;
       //head_->findClient(clientID)->setGamestateID(id);
@@ -203 +206 @@
 
   bool GameStateManager::loadPartialSnapshot(GameState *state, int clientID){
+    if(!state)
+      return false;
     unsigned char *data=state->data;
     COUT(4) << "loadSnapshot: loading gs: " << state->id << std::endl;
@@ -219 +224 @@
       sync.data = data;
       data+=sync.length;
-
+      COUT(4) << "objectID: " << sync.objectID << " classID: " << sync.classID << std::endl;
       while(it && it->objectID!=sync.objectID)
         ++it;
@@ -226 +231 @@
       if(!it){
         // the object does not exist yet
+        COUT(4) << "loadsnapshot: creating new object " << std::endl;
         //COUT(4) << "loadSnapshot:\tclassid: " << sync.classID << ", name: " << ID((unsigned int) sync.classID)->getName() << std::endl;
         orxonox::Identifier* id = ID((unsigned int)sync.classID);
@@ -244 +250 @@
       }else{
         // we have our object
+        COUT(4) << "loadpartialsnapshot: we found the appropriate object" << std::endl;
         if(checkAccess(clientID, sync.objectID)){
           if(! it->updateData(sync))
@@ -396 +403 @@
     //std::cout << "length " << length << std::endl;
     switch ( retval ) {
-      case Z_OK: COUT(4) << "successfully decompressed" << std::endl; break;
+      case Z_OK: COUT(5) << "successfully decompressed" << std::endl; break;
       case Z_MEM_ERROR: COUT(1) << "not enough memory available" << std::endl; return NULL;
       case Z_BUF_ERROR: COUT(2) << "not enough memory available in the buffer" << std::endl; return NULL;
@@ -444 +451 @@
   bool GameStateManager::checkAccess(int clientID, int objectID){
     // currently we only check, wheter the object is the clients spaceship
-    return head_->findClient(objectID)->getShipID()==objectID;
+//     return head_->findClient(objectID)->getShipID()==objectID;
+    return true; // TODO: change this
   }
 

code/branches/network3/src/network/PacketDecoder.cc

@@ -78 +78 @@
       return true;
     case GAMESTATE:
-      gstate( packet );
+      gstate( packet, clientId );
       return true;
     case CLASSID:
@@ -155 +155 @@
   }
 
-  void PacketDecoder::gstate( ENetPacket* packet )
+  void PacketDecoder::gstate( ENetPacket* packet, int clientID )
   {
     GameStateCompressed* currentState = NULL;
@@ -190 +190 @@
     //clean memory
     enet_packet_destroy( packet );
-    processGamestate(currentState);
+    processGamestate(currentState, clientID);
   }
 
@@ -234 +234 @@
   }
 
-  void PacketDecoder::processGamestate( GameStateCompressed *state )
+  void PacketDecoder::processGamestate( GameStateCompressed *state, int clientID )
   {
     COUT(5) << "PacketDecoder: processing Gamestate" << std::endl;

code/branches/network3/src/network/PacketManager.h

@@ -91 +91 @@
     void mousem( ENetPacket* packet, int clientId = CLIENTID_CLIENT );
     void keystrike( ENetPacket* packet, int clientId = CLIENTID_CLIENT );
-    void chatMessage( ENetPacket* packet, int clientId = CLIENTID_CLIENT);
-    void gstate( ENetPacket* packet );
+    void chatMessage( ENetPacket* packet, int clientId = CLIENTID_CLIENT );
+    void gstate( ENetPacket* packet, int clientID = CLIENTID_CLIENT );
     void clid( ENetPacket *packet);
     bool decodeWelcome( ENetPacket* packet, int clientID = CLIENTID_CLIENT );
@@ -99 +99 @@
     //process data
     //two functions are note yet implemented!
-    virtual void processGamestate(GameStateCompressed *state);
+    virtual void processGamestate(GameStateCompressed *state, int clientID);
     virtual void processAck( ack *data, int clientID);
     virtual void processClassid( classid *cid);

code/branches/network3/src/network/Server.cc

@@ -143 +143 @@
     updateGamestate();
 
-    usleep(200000); // TODO remove
+//     usleep(500000); // TODO remove
     return;
   }
@@ -228 +228 @@
     //connection->addPacket(packet_gen.gstate(gamestates->popGameState(clientID)) , clientID);
     connection->createClient(clientID);
+    return true;
+  }
+  
+  void Server::processGamestate( GameStateCompressed *data, int clientID){
+    COUT(4) << "processing partial gamestate from client " << clientID << std::endl;
+    if(!gamestates->pushGameState(data, clientID))
+        COUT(3) << "Could not push gamestate\t\t\t\t=====" << std::endl;
+//     delete[] data->data;
+//     delete data;
   }
 

code/branches/network3/src/network/Server.h

@@ -74 +74 @@
     void processAck( ack *data, int clientID);
     bool processConnectRequest( connectRequest *con, int clientID );
+    void processGamestate( GameStateCompressed *data, int clientID);
     ConnectionManager *connection;
     GameStateManager *gamestates;

code/branches/network3/src/network/Synchronisable.cc

@@ -50 +50 @@
   
   
-  int Synchronisable::state_=1; // detemines wheter we are server (default) or client
+  int Synchronisable::state_=0x1; // detemines wheter we are server (default) or client
   
   /**
@@ -165 +165 @@
     for(i=syncList->begin(); n<datasize && i!=syncList->end(); ++i){
       //(std::memcpy(retVal.data+n, (const void*)(&(i->size)), sizeof(int));
-      if( ((*i)->mode & state_) == 0 )
+      if( ((*i)->mode & state_) == 0 ){
+        COUT(4) << "not getting data: " << std::endl;
         continue;  // this variable should only be received
+      }
       switch((*i)->type){
       case DATA:
@@ -199 +201 @@
     COUT(5) << "Synchronisable: objectID " << vars.objectID << ", classID " << vars.classID << " size: " << vars.length << " synchronising data" << std::endl;
     for(i=syncList->begin(); i!=syncList->end(); i++){
-      if( ((*i)->mode ^ state_) == 0 )
-        continue;  // this variable should only be sent
+      if( ((*i)->mode ^ state_) == 0 ){
+        COUT(5) << "synchronisable: not updating variable " << std::endl;
+        continue;  // this variable should only be updated
+      }
       COUT(5) << "Synchronisable: element size: " << (*i)->size << " type: " << (*i)->type << std::endl;
       switch((*i)->type){