Changeset 1646 for code/branches/gui/src/core

Timestamp:

Jul 24, 2008, 10:40:22 PM (16 years ago)

Author:

rgrieder

Message:

• privatised InputState c'tors
• added destruction code for GUIManager
• fixed some issues and bugs
• found 2400 memory leaks
• haven't done anything about it
• converted GUIManager to Ogre Singleton
• added NULL checkers in Loader

Location:

code/branches/gui/src/core

Files:

• Loader.cc (modified) (4 diffs)
• input/ExtendedInputState.h (modified) (2 diffs)
• input/InputManager.cc (modified) (4 diffs)
• input/InputState.h (modified) (2 diffs)
• input/SimpleInputState.h (modified) (2 diffs)

code/branches/gui/src/core/Loader.cc

@@ -64 +64 @@
     void Loader::add(const Level* level, const ClassTreeMask& mask)
     {
+        if (!level)
+            return;
         Loader::levels_s.insert(Loader::levels_s.end(), std::pair<const Level*, ClassTreeMask>(level, mask));
     }
@@ -69 +71 @@
     void Loader::remove(const Level* level)
     {
+        if (!level)
+            return;
         for (std::vector<std::pair<const Level*, ClassTreeMask> >::iterator it = Loader::levels_s.begin(); it != Loader::levels_s.end(); ++it)
         {
@@ -108 +112 @@
     bool Loader::load(const Level* level, const ClassTreeMask& mask)
     {
+        if (!level)
+            return false;
+
         Loader::currentMask_s = level->getMask() * mask;
 
@@ -165 +172 @@
     void Loader::unload(const Level* level, const ClassTreeMask& mask)
     {
+        if (!level)
+            return;
         for (Iterator<BaseObject> it = ObjectList<BaseObject>::begin(); it; )
         {

code/branches/gui/src/core/input/ExtendedInputState.h

@@ -47 +47 @@
     class _CoreExport ExtendedInputState : public InputState
     {
+        friend class InputManager;
+        friend class ClassFactory<ExtendedInputState>;
+
     public:
-        ExtendedInputState();
-        ~ExtendedInputState() { }
-
         bool addKeyHandler        (KeyHandler* handler);
         bool removeKeyHandler     (KeyHandler* handler);
@@ -68 +68 @@
 
     private:
+        ExtendedInputState();
+        ~ExtendedInputState() { }
+
         void tickInput(float dt);
         void tickInput(float dt, unsigned int device);

code/branches/gui/src/core/input/InputManager.cc

@@ -429 +429 @@
                     (*rit).second->onLeave();
                 }
-                activeStates_.clear();
-                _updateActiveStates();
+                //activeStates_.clear();
+                //_updateActiveStates();
 
                 // destroy all input states
@@ -438 +438 @@
                 }
 
-                stateEmpty_ = 0;
-                stateCalibrator_ = 0;
-                stateDetector_ = 0;
+                //stateEmpty_ = 0;
+                //stateCalibrator_ = 0;
+                //stateDetector_ = 0;
 
                 // destroy the devices
@@ -448 +448 @@
 
                 // 0 joy sticks now
-                _redimensionLists();
+                //_redimensionLists();
 
                 OIS::InputManager::destroyInputSystem(inputSystem_);
-                inputSystem_ = 0;
+                //inputSystem_ = 0;
 
                 CCOUT(3) << "Destroying done." << std::endl;
@@ -509 +509 @@
     {
         assert(state);
+        std::map<int, InputState*>::iterator it = this->activeStates_.find(state->getPriority());
+        if (it != this->activeStates_.end())
+        {
+            this->activeStates_.erase(it);
+            _updateActiveStates();
+        }
         inputStatesByPriority_.erase(state->getPriority());
         inputStatesByName_.erase(state->getName());

code/branches/gui/src/core/input/InputState.h

@@ -51 +51 @@
 
     public:
-        InputState() : priority_(0), executorOnEnter_(0), executorOnLeave_(0)
-        { RegisterObject(InputState); }
-        virtual ~InputState() { }
-
         const std::string& getName() const { return name_; }
         int getPriority()            const { return priority_; }
@@ -93 +89 @@
 
     protected:
+        InputState() : priority_(0), executorOnEnter_(0), executorOnLeave_(0)
+        { RegisterObject(InputState); }
+        virtual ~InputState() { }
+
         virtual void numberOfJoySticksChanged(unsigned int n) = 0;
         void setInputDeviceEnabled(unsigned int device, bool bEnabled)

code/branches/gui/src/core/input/SimpleInputState.h

@@ -45 +45 @@
     class _CoreExport SimpleInputState : public InputState
     {
+        friend class InputManager;
+        friend class ClassFactory<SimpleInputState>;
+
     public:
-        SimpleInputState();
-        ~SimpleInputState() { }
-
         void setKeyHandler        (KeyHandler* handler) { keyHandler_ = handler; update(); }
         void setMouseHandler      (MouseHandler* handler) { mouseHandler_ = handler; update(); }
@@ -57 +57 @@
 
     private:
+        SimpleInputState();
+        ~SimpleInputState() { }
+
         void tickInput(float dt);
         void tickInput(float dt, unsigned int device);