Changeset 1784 for code/trunk/src/core

Timestamp:

Sep 15, 2008, 10:54:25 AM (16 years ago)

Author:

rgrieder

Message:

• removed obsolete Convert.h includes (possibly from old XML loading)
• replaced tabs in audio library, plus minor code cleanup because removing the tabs screwed layout
• replaced all "#define name number" with "const Type name = number" if possible

Location:

code/trunk/src/core

Files:

• ArgumentCompletionListElement.h (modified) (1 diff)
• CommandExecutor.cc (modified) (1 diff)
• ConfigFileManager.cc (modified) (1 diff)
• ConfigFileManager.h (modified) (1 diff)
• ConfigValueContainer.cc (modified) (1 diff)
• Functor.h (modified) (1 diff)
• IRC.cc (modified) (1 diff)
• TclThreadManager.cc (modified) (1 diff)

code/trunk/src/core/ArgumentCompletionListElement.h

@@ -35 +35 @@
 #include <list>
 
-#define ACL_MODE_NORMAL    1
-#define ACL_MODE_LOWERCASE 2
-#define ACL_MODE_DISPLAY   4
 
 namespace orxonox
 {
+    const int ACL_MODE_NORMAL    = 1;
+    const int ACL_MODE_LOWERCASE = 2;
+    const int ACL_MODE_DISPLAY   = 4;
+
     typedef std::list<ArgumentCompletionListElement> ArgumentCompletionList;
 

code/trunk/src/core/CommandExecutor.cc

@@ -30 +30 @@
 #include "ConsoleCommand.h"
 #include "util/String.h"
-#include "util/Convert.h"
 #include "util/Debug.h"
 #include "Identifier.h"

code/trunk/src/core/ConfigFileManager.cc

@@ -34 +34 @@
 #include "util/String.h"
 
-#define CONFIG_FILE_MAX_LINELENGHT 1024
 
 namespace orxonox
 {
+    const int CONFIG_FILE_MAX_LINELENGHT  = 1024;
+    const char* const DEFAULT_CONFIG_FILE = "default.ini";
+
     SetConsoleCommandShortcutExtern(config).argumentCompleter(0, autocompletion::configvalueclasses()).argumentCompleter(1, autocompletion::configvalues()).argumentCompleter(2, autocompletion::configvalue());
     SetConsoleCommandShortcutExtern(tconfig).argumentCompleter(0, autocompletion::configvalueclasses()).argumentCompleter(1, autocompletion::configvalues()).argumentCompleter(2, autocompletion::configvalue());

code/trunk/src/core/ConfigFileManager.h

@@ -38 +38 @@
 
 #include "util/Math.h"
-
-#define DEFAULT_CONFIG_FILE "default.ini"
 
 namespace orxonox

code/trunk/src/core/ConfigValueContainer.cc

@@ -41 +41 @@
 #include "Identifier.h"
 
-#define MAX_VECTOR_INDEX 255 // to avoid up to 4*10^9 vector entries in the config file after accidentally using a wrong argument
 
 
 namespace orxonox
 {
+    const int MAX_VECTOR_INDEX  = 255; // to avoid up to 4*10^9 vector entries in the config file after accidentally using a wrong argument
+
     /**
         @brief Initializes the ConfigValueContainer with defaultvalues.

code/trunk/src/core/Functor.h

@@ -36 +36 @@
 #include "util/Debug.h"
 
-#define MAX_FUNCTOR_ARGUMENTS 5
 
 namespace orxonox
 {
+    const int MAX_FUNCTOR_ARGUMENTS = 5;
+
     enum FunctionType
     {

code/trunk/src/core/IRC.cc

@@ -35 +35 @@
 #include "util/Convert.h"
 
-#define IRC_TCL_THREADID 1421421421
 
 namespace orxonox
 {
+    static const unsigned int IRC_TCL_THREADID  = 1421421421;
+
     SetConsoleCommand(IRC, say,  true).accessLevel(AccessLevel::User);
     SetConsoleCommand(IRC, msg,  false).accessLevel(AccessLevel::User);

code/trunk/src/core/TclThreadManager.cc

@@ -43 +43 @@
 #include "util/Convert.h"
 
-#define TCLTHREADMANAGER_MAX_QUEUE_LENGTH 100
-#define TCLTHREADMANAGER_MAX_CPU_USAGE 0.50
 
 namespace orxonox
 {
+    const int TCLTHREADMANAGER_MAX_QUEUE_LENGTH = 100;
+    const int TCLTHREADMANAGER_MAX_CPU_USAGE    = 0.50;
+
     SetConsoleCommandShortcutAlias(TclThreadManager, execute, "tclexecute").argumentCompleter(0, autocompletion::tclthreads());
     SetConsoleCommandShortcutAlias(TclThreadManager, query,   "tclquery"  ).argumentCompleter(0, autocompletion::tclthreads());