Changeset 2549

Timestamp:

Dec 30, 2008, 3:27:39 PM (16 years ago)

Author:

rgrieder

Message:

Moved tick time measurement to GSRoot. The values get combined with the one from GSGraphics.

Location:

code/branches/presentation/src

Files:

• core/RootGameState.cc (modified) (1 diff)
• orxonox/gamestates/GSDedicated.cc (modified) (2 diffs)
• orxonox/gamestates/GSGraphics.cc (modified) (7 diffs)
• orxonox/gamestates/GSGraphics.h (modified) (3 diffs)
• orxonox/gamestates/GSLevel.h (modified) (1 diff)
• orxonox/gamestates/GSRoot.cc (modified) (4 diffs)
• orxonox/gamestates/GSRoot.h (modified) (4 diffs)

code/branches/presentation/src/core/RootGameState.cc

@@ -122 +122 @@
     /**
     @brief
+        Main loop of the orxonox game.
         Starts the game. The little 'while' denotes the main loop.
         Whenever the root state is selected, the game ends.
     @param name
         State to start with (usually main menu or specified by command line)
+    @note
+        We use the Ogre::Timer to measure time since it uses the most precise
+        method an a platform (however the windows timer lacks time when under
+        heavy kernel load!).
     */
     void RootGameState::start()

code/branches/presentation/src/orxonox/gamestates/GSDedicated.cc

@@ -74 +74 @@
     void GSDedicated::ticked(const Clock& time)
     {
-//         static float startTime = time.getSecondsPrecise();
-//         static int nrOfTicks = 0;
-        timeSinceLastUpdate_+=time.getDeltaTime();
-        if(timeSinceLastUpdate_>=NETWORK_PERIOD){
-//             ++nrOfTicks;
-//             COUT(0) << "estimated ticks/sec: " << nrOfTicks/(time.getSecondsPrecise()-startTime) << endl;
-            timeSinceLastUpdate_ -= static_cast<unsigned int>( timeSinceLastUpdate_ / NETWORK_PERIOD ) * NETWORK_PERIOD;
+//        static float startTime = time.getSecondsPrecise();
+//        static int nrOfTicks = 0;
+        timeSinceLastUpdate_ += time.getDeltaTime();
+        if (timeSinceLastUpdate_ >= NETWORK_PERIOD)
+        {
+//            ++nrOfTicks;
+//            COUT(0) << "estimated ticks/sec: " << nrOfTicks/(time.getSecondsPrecise()-startTime) << endl;
+            timeSinceLastUpdate_ -= static_cast<unsigned int>(timeSinceLastUpdate_ / NETWORK_PERIOD) * NETWORK_PERIOD;
             GSLevel::ticked(time);
             server_->tick(time.getDeltaTime());
@@ -87 +88 @@
         else
         {
-            usleep( (int)( (NETWORK_PERIOD - timeSinceLastUpdate_)*1000*1000 ) );
-//             COUT(0) << "sleeping for " << (int)( (NETWORK_PERIOD - timeSinceLastUpdate_)*1000*1000 ) << " usec" << endl;
+            usleep((int)((NETWORK_PERIOD - timeSinceLastUpdate_) * 1000 * 1000));
+//            COUT(0) << "sleeping for " << (int)((NETWORK_PERIOD - timeSinceLastUpdate_) * 1000 * 1000) << " usec" << endl;
         }
     }

code/branches/presentation/src/orxonox/gamestates/GSGraphics.cc

@@ -76 +76 @@
         , graphicsEngine_(0)
         , masterKeyBinder_(0)
-        , frameCount_(0)
-        , statisticsRefreshCycle_(0)
-        , statisticsStartTime_(0)
-        , statisticsStartCount_(0)
-        , tickTime_(0)
         , debugOverlay_(0)
     {
@@ -107 +102 @@
         SetConfigValue(ogreLogLevelCritical_, 2)
             .description("Corresponding orxonox debug level for ogre Critical");
-        SetConfigValue(statisticsRefreshCycle_, 250000)
-            .description("Sets the time in microseconds interval at which average fps, etc. get updated.");
-        SetConfigValue(statisticsAvgLength_, 1000000)
-            .description("Sets the time in microseconds interval at which average fps, etc. gets calculated.");
         SetConfigValue(defaultMasterKeybindings_, "def_masterKeybindings.ini")
             .description("Filename of default master keybindings.");
@@ -158 +149 @@
         guiManager_->initialise(this->renderWindow_);
 
-        // reset frame counter
-        this->frameCount_ = 0;
-        this->tickTime_ = 0;
-        statisticsStartTime_ = 0;
-        statisticsStartCount_ = 0;
-
         // add console commands
         FunctorMember<GSGraphics>* functor1 = createFunctor(&GSGraphics::printScreen);
@@ -228 +213 @@
 
     /**
-        Main loop of the orxonox game.
-        We use the Ogre::Timer to measure time since it uses the most precise
-        method an a platform (however the windows timer lacks time when under
-        heavy kernel load!).
-        There is a simple mechanism to measure the average time spent in our
-        ticks as it may indicate performance issues.
+    @note
         A note about the Ogre::FrameListener: Even though we don't use them,
         they still get called. However, the delta times are not correct (except
@@ -243 +223 @@
     {
         uint64_t timeBeforeTick = time.getRealMicroseconds();
+
         float dt = time.getDeltaTime();
 
@@ -259 +240 @@
         uint64_t timeAfterTick = time.getRealMicroseconds();
 
-        statisticsTickInfo tickInfo = {timeAfterTick, timeAfterTick-timeBeforeTick};
-        statisticsTickTimes_.push_front( tickInfo );
-        tickTime_ += (unsigned int)(timeAfterTick - timeBeforeTick);
-        if (timeAfterTick > statisticsStartTime_ + statisticsRefreshCycle_)
-        {
-            while( (statisticsTickTimes_.size()!=0) && (statisticsTickTimes_.back().tickTime < timeAfterTick - statisticsAvgLength_ ) )
-                statisticsTickTimes_.pop_back();
-            std::deque<statisticsTickInfo>::iterator it = statisticsTickTimes_.begin();
-            uint32_t periodTickTime = 0;
-            unsigned int periodNrOfTicks = 0;
-            while ( it!=statisticsTickTimes_.end() )
-            {
-                periodTickTime += it->tickLength;
-                periodNrOfTicks++;
-                ++it;
-            }
-            float avgFPS = (float)periodNrOfTicks/(statisticsTickTimes_.front().tickTime - statisticsTickTimes_.back().tickTime)*1000000.0;
-            float avgTickTime = (float)periodTickTime/periodNrOfTicks/1000.0;
-            //float avgFPS = (float)statisticsTickTimes_.size()/statisticsAvgLength_*1000000.0;
-            GraphicsEngine::getInstance().setAverageFramesPerSecond(avgFPS);
-            //GraphicsEngine::getInstance().setAverageTickTime( 
-              //(float)tickTime_ * 0.001f / (frameCount_ - statisticsStartCount_));
-            GraphicsEngine::getInstance().setAverageTickTime( avgTickTime );
-
-            tickTime_ = 0;
-            statisticsStartCount_ = frameCount_;
-            statisticsStartTime_  = timeAfterTick;
-        }
+        // Also add our tick time to the list in GSRoot
+        this->getParent()->addTickTime(timeAfterTick - timeBeforeTick);
+
+        // Update statistics overlay. Note that the values only change periodically in GSRoot.
+        GraphicsEngine::getInstance().setAverageFramesPerSecond(this->getParent()->getAvgFPS());
+        GraphicsEngine::getInstance().setAverageTickTime(this->getParent()->getAvgTickTime());
 
         // don't forget to call _fireFrameStarted in ogre to make sure
@@ -307 +266 @@
         // again, just to be sure ogre works fine
         ogreRoot_->_fireFrameEnded(evt); // note: uses the same time as _fireFrameStarted
-
-        ++frameCount_;
     }
 

code/branches/presentation/src/orxonox/gamestates/GSGraphics.h

@@ -37 +37 @@
 #include "GSRoot.h"
 
-#include <deque>
-
 namespace orxonox
 {
-    struct statisticsTickInfo{
-        uint64_t    tickTime;
-        uint32_t    tickLength;
-    };
-    
     class _OrxonoxExport GSGraphics : public GameState<GSRoot>, public OrxonoxClass,
                                       public Ogre::WindowEventListener, public Ogre::LogListener
@@ -100 +93 @@
 
         KeyBinder*            masterKeyBinder_;
-
-        // variables for time statistics
-        unsigned long         frameCount_;
-        unsigned int          statisticsRefreshCycle_;
-        unsigned int          statisticsAvgLength_;
-        unsigned long long    statisticsStartTime_;
-        unsigned long         statisticsStartCount_;
-        std::deque<statisticsTickInfo>
-            statisticsTickTimes_;
-        unsigned int          tickTime_;
         XMLFile*              debugOverlay_;
 
@@ -120 +103 @@
         int                   ogreLogLevelNormal_;       //!< Corresponding Orxonx debug level for LL_NORMAL
         int                   ogreLogLevelCritical_;     //!< Corresponding Orxonx debug level for LL_CRITICAL
-        unsigned int          detailLevelParticle_;      //!< Detail level of particle effects (0: off, 1: low, 2: normal, 3: high)
         std::string           defaultMasterKeybindings_; //!< Filename of default master keybindings.
 

code/branches/presentation/src/orxonox/gamestates/GSLevel.h

@@ -33 +33 @@
 #include <OgrePrerequisites.h>
 #include "core/GameState.h"
-#include "GSGraphics.h"
 
 namespace orxonox
 {
-    class _OrxonoxExport GSLevel : public OrxonoxClass //,public GameState<GSGraphics>
+    class _OrxonoxExport GSLevel : public OrxonoxClass
     {
         friend class ClassIdentifier<GSLevel>;

code/branches/presentation/src/orxonox/gamestates/GSRoot.cc

@@ -89 +89 @@
     void GSRoot::setConfigValues()
     {
+        SetConfigValue(statisticsRefreshCycle_, 250000)
+            .description("Sets the time in microseconds interval at which average fps, etc. get updated.");
+        SetConfigValue(statisticsAvgLength_, 1000000)
+            .description("Sets the time in microseconds interval at which average fps, etc. gets calculated.");
     }
 
@@ -98 +102 @@
         // reset game speed to normal
         timeFactor_ = 1.0f;
+
+        // reset frame counter
+        this->frameCount_ = 0;
+        this->statisticsStartTime_ = 0;
+        this->statisticsTickTimes_.clear();
+        this->periodTickTime_ = 0;
+        this->avgFPS_ = 0.0f;
+        this->avgTickTime_ = 0.0f;
 
         // Create the lua interface
@@ -189 +201 @@
     void GSRoot::ticked(const Clock& time)
     {
+        uint64_t timeBeforeTick = time.getRealMicroseconds();
+
         TclThreadManager::getInstance().tick(time.getDeltaTime());
 
@@ -206 +220 @@
         /*** HACK *** HACK ***/
 
+        uint64_t timeAfterTick = time.getRealMicroseconds();
+
+        // STATISTICS
+        statisticsTickInfo tickInfo = {timeAfterTick, timeAfterTick - timeBeforeTick};
+        statisticsTickTimes_.push_back(tickInfo);
+
+        // Ticks GSGraphics or GSDedicated
         this->tickChild(time);
+
+        // Note: tickInfo.tickLength is modified by GSGraphics or GSDedicated!
+        this->periodTickTime_ += tickInfo.tickLength;
+        if (timeAfterTick > statisticsStartTime_ + statisticsRefreshCycle_)
+        {
+            while (statisticsTickTimes_.front().tickTime < timeAfterTick - statisticsAvgLength_)
+            {
+                this->periodTickTime_ -= this->statisticsTickTimes_.front().tickLength;
+                this->statisticsTickTimes_.pop_front();
+            }
+
+            uint32_t framesPerPeriod = this->statisticsTickTimes_.size();
+            this->avgFPS_ = (float)framesPerPeriod / (tickInfo.tickTime - this->statisticsTickTimes_.front().tickTime) * 1000000.0;
+            this->avgTickTime_ = (float)this->periodTickTime_ / framesPerPeriod / 1000.0;
+
+            statisticsStartTime_ = timeAfterTick;
+        }
+
+        ++this->frameCount_;
     }
 

code/branches/presentation/src/orxonox/gamestates/GSRoot.h

@@ -31 +31 @@
 
 #include "OrxonoxPrereqs.h"
+
+#include <list>
 #include <OgreLog.h>
 #include "core/RootGameState.h"
@@ -40 +42 @@
     {
         friend class ClassIdentifier<GSRoot>;
+
+    public:
+        struct statisticsTickInfo
+        {
+            uint64_t    tickTime;
+            uint32_t    tickLength;
+        };
+    
     public:
         GSRoot();
@@ -52 +62 @@
         void pause();
         float getTimeFactor() { return this->timeFactor_; }
+
+        float getAvgTickTime() { return this->avgTickTime_; }
+        float getAvgFPS()      { return this->avgFPS_; }
+
+        inline void addTickTime(uint32_t length)
+            { assert(!this->statisticsTickTimes_.empty()); this->statisticsTickTimes_.back().tickLength += length; }
 
     private:
@@ -69 +85 @@
         Shell*                shell_;
         LuaBind*              luaBind_;
+
+        // variables for time statistics
+        uint32_t              frameCount_;
+        uint64_t              statisticsStartTime_;
+        std::list<statisticsTickInfo>
+                              statisticsTickTimes_;
+        uint32_t              periodTickTime_;
+        float                 avgFPS_;
+        float                 avgTickTime_;
+
+        // config values
+        unsigned int          statisticsRefreshCycle_;
+        unsigned int          statisticsAvgLength_;
 
         // console commands