Changeset 3288

Timestamp:

Jul 13, 2009, 10:43:59 PM (15 years ago)

Author:

rgrieder

Message:

Finally found a satisfying way to deal with interfaces that deliver information, but only upon virtual call.
The solution involves a static variable but any other (and uglier/hackier) solution will do so too.
I applied the method the the JoyStickQuantityListener so that the KeyBinder is now independent on the InputManager.

Location:

code/branches/core4/src/core/input

Files:

• InputManager.cc (modified) (3 diffs)
• InputState.cc (modified) (3 diffs)
• InputState.h (modified) (1 diff)
• JoyStickQuantityListener.cc (modified) (1 diff)
• JoyStickQuantityListener.h (modified) (1 diff)
• KeyBinder.cc (modified) (3 diffs)
• KeyBinder.h (modified) (1 diff)
• KeyDetector.cc (modified) (1 diff)
• KeyDetector.h (modified) (1 diff)

code/branches/core4/src/core/input/InputManager.cc

@@ -260 +260 @@
 
         // inform all JoyStick Device Number Listeners
-        for (ObjectList<JoyStickQuantityListener>::iterator it = ObjectList<JoyStickQuantityListener>::begin(); it; ++it)
-            it->JoyStickQuantityChanged(devices_.size() - InputDeviceEnumerator::FirstJoyStick);
+        std::vector<JoyStick*> joyStickList;
+        for (unsigned int i = InputDeviceEnumerator::FirstJoyStick; i < devices_.size(); ++i)
+            joyStickList.push_back(static_cast<JoyStick*>(devices_[i]));
+        JoyStickQuantityListener::changeJoyStickQuantity(joyStickList);
     }
 
@@ -572 +574 @@
         if (statesByName_.find(name) == statesByName_.end())
         {
-            InputState* state = new InputState;
             if (priority >= InputStatePriority::HighPriority || priority == InputStatePriority::Empty)
             {
@@ -583 +584 @@
                         COUT(2) << "Warning: Could not add an InputState with the same priority '"
                             << static_cast<int>(priority) << "' != 0." << std::endl;
-                        return false;
+                        return 0;
                     }
                 }
             }
+            InputState* state = new InputState(name, bAlwaysGetsInput, bTransparent, priority);
             statesByName_[name] = state;
-            state->JoyStickQuantityChanged(devices_.size() - InputDeviceEnumerator::FirstJoyStick);
-            state->setName(name);
-            state->bAlwaysGetsInput_ = bAlwaysGetsInput;
-            state->bTransparent_ = bTransparent;
-            if (priority >= InputStatePriority::HighPriority || priority == InputStatePriority::Empty)
-                state->setPriority(priority);
 
             return state;

code/branches/core4/src/core/input/InputState.cc

@@ -32 +32 @@
 namespace orxonox
 {
-    InputState::InputState()
-        : priority_(0)
-        , bAlwaysGetsInput_(false)
-        , bTransparent_(false)
+    InputState::InputState(const std::string& name, bool bAlwaysGetsInput, bool bTransparent, InputStatePriority priority)
+        : name_(name)
+        , bAlwaysGetsInput_(bAlwaysGetsInput)
+        , bTransparent_(bTransparent)
         , bExpired_(true)
         , handlers_(2)
@@ -42 +42 @@
         , leaveFunctor_(0)
     {
+        if (priority >= InputStatePriority::HighPriority || priority == InputStatePriority::Empty)
+            priority_ = priority;
+        else
+            priority_ = 0;
+
+        handlers_.resize(InputDeviceEnumerator::FirstJoyStick + JoyStickQuantityListener::getJoyStickList().size(), NULL);
     }
 
@@ -52 +58 @@
     }
 
-    void InputState::JoyStickQuantityChanged(unsigned int n)
+    void InputState::JoyStickQuantityChanged(const std::vector<JoyStick*>& joyStickList)
     {
         unsigned int oldSize = handlers_.size();
-        handlers_.resize(InputDeviceEnumerator::FirstJoyStick + n, NULL);
+        handlers_.resize(InputDeviceEnumerator::FirstJoyStick + joyStickList.size(), NULL);
 
         for (unsigned int i = oldSize; i < handlers_.size(); ++i)

code/branches/core4/src/core/input/InputState.h

@@ -97 +97 @@
 
     private:
-        InputState();
+        InputState(const std::string& name, bool bAlwaysGetsInput, bool bTransparent, InputStatePriority priority);
         ~InputState() { }
 
-        void JoyStickQuantityChanged(unsigned int n);
+        void JoyStickQuantityChanged(const std::vector<JoyStick*>& joyStickList);
 
-        void setName(const std::string& name) { name_ = name; }
-        void setPriority(int priority)        { priority_ = priority; }
+        void setPriority(int priority) { priority_ = priority; }
 
-        std::string                 name_;
+        const std::string           name_;
+        const bool                  bAlwaysGetsInput_;
+        const bool                  bTransparent_;
         int                         priority_;
-        bool                        bAlwaysGetsInput_;
-        bool                        bTransparent_;
         bool                        bExpired_;
         std::vector<InputHandler*>  handlers_;

code/branches/core4/src/core/input/JoyStickQuantityListener.cc

@@ -28 +28 @@
 
 #include "JoyStickQuantityListener.h"
+
 #include "core/CoreIncludes.h"
+#include "core/ObjectList.h"
 
 namespace orxonox
 {
+    std::vector<JoyStick*> JoyStickQuantityListener::joyStickList_s;
+
     JoyStickQuantityListener::JoyStickQuantityListener()
     {
         RegisterObject(JoyStickQuantityListener);
     }
+
+    //! Calls all registered objects and sets the static variable
+    /*static*/ void JoyStickQuantityListener::changeJoyStickQuantity(const std::vector<JoyStick*>& joyStickList)
+    {
+        joyStickList_s = joyStickList;
+        for (ObjectList<JoyStickQuantityListener>::iterator it = ObjectList<JoyStickQuantityListener>::begin(); it; ++it)
+            it->JoyStickQuantityChanged(joyStickList);
+    }
 }

code/branches/core4/src/core/input/JoyStickQuantityListener.h

@@ -43 +43 @@
     class _CoreExport JoyStickQuantityListener : virtual public OrxonoxClass
     {
+        friend InputManager;
     public:
         JoyStickQuantityListener();
         virtual ~JoyStickQuantityListener() { }
 
-        //! Called when joy sticks get added/removed
-        virtual void JoyStickQuantityChanged(unsigned int value) = 0;
+        //! Returns a list with all JoySticks currently loaded
+        const std::vector<JoyStick*>& getJoyStickList() const { return joyStickList_s; }
+
+    private:
+        //! Called whenever joy sticks get added/removed
+        virtual void JoyStickQuantityChanged(const std::vector<JoyStick*>& joyStickList) = 0;
+
+        static void changeJoyStickQuantity(const std::vector<JoyStick*>& joyStickList);
+
+        //! Static variable that holds the latest distributed information
+        static std::vector<JoyStick*> joyStickList_s;
     };
 }

code/branches/core4/src/core/input/KeyBinder.cc

@@ -40 +40 @@
 #include "core/ConfigFileManager.h"
 #include "InputCommands.h"
-#include "InputManager.h"
 
 namespace orxonox
@@ -103 +102 @@
 
         // initialise joy sticks separatly to allow for reloading
-        numberOfJoySticks_ = InputManager::getInstance().getJoyStickQuantity();
+        numberOfJoySticks_ = this->getJoyStickList().size();
         initialiseJoyStickBindings();
 
@@ -155 +154 @@
     }
 
-    void KeyBinder::JoyStickQuantityChanged(unsigned int value)
+    void KeyBinder::JoyStickQuantityChanged(const std::vector<JoyStick*>& joyStickList)
     {
         unsigned int oldValue = numberOfJoySticks_;
-        numberOfJoySticks_ = value;
+        numberOfJoySticks_ = joyStickList.size();
 
         // initialise joy stick bindings

code/branches/core4/src/core/input/KeyBinder.h

@@ -76 +76 @@
         void buttonThresholdChanged();
         // from JoyStickQuantityListener interface
-        virtual void JoyStickQuantityChanged(unsigned int value);
+        virtual void JoyStickQuantityChanged(const std::vector<JoyStick*>& joyStickList);
         void initialiseJoyStickBindings();
         void compilePointerLists();

code/branches/core4/src/core/input/KeyDetector.cc

@@ -73 +73 @@
     }
 
-    void KeyDetector::JoyStickQuantityChanged(unsigned int value)
+    void KeyDetector::JoyStickQuantityChanged(const std::vector<JoyStick*>& joyStickList)
     {
-        KeyBinder::JoyStickQuantityChanged(value);
+        KeyBinder::JoyStickQuantityChanged(joyStickList);
         setCallbackCommand(callbackCommand_);
     }

code/branches/core4/src/core/input/KeyDetector.h

@@ -49 +49 @@
         ~KeyDetector();
         void setCallbackCommand(const std::string& command);
-        void JoyStickQuantityChanged(unsigned int value);
+        void JoyStickQuantityChanged(const std::vector<JoyStick*>& joyStickList);
 
     private: