Changeset 5192 in orxonox.OLD for trunk/src

Timestamp:

Sep 18, 2005, 12:49:27 AM (19 years ago)

Author:

bensch

Message:

orxonox/trunk: more completion issues

Location:

trunk/src/lib/shell

Files:

• shell_command.cc (modified) (1 diff)
• shell_completion.cc (modified) (13 diffs)
• shell_completion.h (modified) (2 diffs)

trunk/src/lib/shell/shell_command.cc

@@ -63 +63 @@
 bool ShellCommandClass::getCommandListOfClass(const char* className, tList<const char>* stringList)
 {
-  if (stringList == NULL)
+  if (stringList == NULL || className == NULL)
     return false;
 

trunk/src/lib/shell/shell_completion.cc

@@ -69 +69 @@
   tList<BaseObject>* objectList;   //< the list of Objects stored in classID
   bool emptyComplete = false;      //< if the completion input is empty string. e.g ""
+  SHELLC_TYPE firstType = SHELLC_NONE;
+  SHELLC_TYPE secondType = SHELLC_NONE;
 
 
@@ -101 +103 @@
     PRINTF(5)("Listing all Classes\n");
     this->objectComplete("", CL_SHELL_COMMAND_CLASS);
-    return false;
   }
   else if (inputSplits.getCount() == 1 && emptyComplete == false)
@@ -110 +111 @@
 
   // OBJECT/FUNCTION COMPLETIONS
-  else if ( (inputSplits.getCount() == 1 && emptyComplete == true ) ||
-             (inputSplits.getCount() == 2 && emptyComplete == false))
+  else if ((inputSplits.getCount() == 1 && emptyComplete == true) ||
+            (inputSplits.getCount() == 2 && emptyComplete == false))
   {
     classID = ClassList::StringToID(inputSplits.getString(0));
     if (classID == CL_NULL)
+    {
       return false;
-    if (inputSplits.getCount()==2)
-    {
-      if  (completionLine[strlen(completionLine)-1] != ' ')
-       this->objectComplete(inputSplits.getString(1), classID);
     }
     else
-      this->objectComplete("", classID);
-  }
-//  else if (inputSplits.getCount() <= 3 )
-
-/*  completionLine = new char[strlen(this->input->getText())+1];
-  strcpy(completionLine, this->input->getText());
-
-  char* commandBegin = strrchr(completionLine, ' ');
-  if (commandBegin == NULL)
-    commandBegin = completionLine;
+    {
+      firstType = SHELLC_CLASS;
+      if (inputSplits.getCount() == 2)
+      {
+        if  (completionLine[strlen(completionLine)-1] != ' ')
+          this->objectComplete(inputSplits.getString(1), classID);
+      }
+      else
+        this->objectComplete("", classID);
+    }
+  }
+
+  if (emptyComplete == false)
+    this->generalComplete(inputSplits.getString(inputSplits.getCount()-1));
   else
-  {
-    if(commandBegin >= completionLine + strlen(completionLine))
-      commandBegin = completionLine + strlen(completionLine);
-    else
-      commandBegin++;
-  }
-
-  char* objectStart;
-  if (objectStart = strstr(commandBegin, "::"))
-  {
-    char* classIdentity = new char[objectStart - commandBegin +1];
-    strncpy(classIdentity, commandBegin, objectStart - commandBegin);
-    classIdentity[objectStart - commandBegin] = '\0';
-    this->objectComplete(objectStart+2, ClassList::StringToID(classIdentity));
-    delete[] classIdentity;
-  }
-  else
-    this->classComplete(commandBegin);
-
-  delete[] completionLine;*/
+    this->generalComplete("");
 }
 
@@ -167 +150 @@
   if (clList != NULL)
   {
-    const tList<ShellC_Element>* classList = this->addToCompleteList(clList, classBegin);
-    if (classList != NULL)
-      this->generalComplete(classList, classBegin, "CL: %s ");
-    else
+    if (!this->addToCompleteList(clList, classBegin))
       return false;
-    delete classList;
   }
   else
@@ -193 +172 @@
   {
     //printf("%s\n", boList->firstElement()->getName());
-    const tList<ShellC_Element>* objectList = this->addToCompleteList(boList, objectBegin);
-    if (objectList != NULL)
-      this->generalComplete(objectList, objectBegin, "%s ");
-    else
+    if (!this->addToCompleteList(boList, objectBegin))
       return false;
   }
@@ -214 +190 @@
 /**
  * completes the inputline on grounds of an inputList
- * @param stringList the List to parse through
  * @param begin the String to search in the inputList, and to extend with it.
  * @param displayAs how to display the found value to the user, printf-style, !!with only one %s!! ex.: "::%s::"
@@ -221 +196 @@
  * @return true if ok, false otherwise
  */
-bool ShellCompletion::generalComplete(const tList<ShellC_Element>* stringList, const char* begin, const char* displayAs, const char* addBack, const char* addFront)
-{
-  if (stringList == NULL || this->input == NULL )
-    return false;
-  if (stringList->getSize() == 0)
-    return false;
-
-  ShellC_Element* addElem = stringList->firstElement();
+bool ShellCompletion::generalComplete(const char* begin, const char* displayAs, const char* addBack, const char* addFront)
+{
+  if (completionList == NULL || this->input == NULL )
+    return false;
+  if (completionList->getSize() == 0)
+    return false;
+
+  ShellC_Element* addElem = completionList->firstElement();
   const char* addString = addElem->name;
   unsigned int addLength = 0;
@@ -236 +211 @@
   if (addString != NULL)
     addLength = strlen(addString);
-  tIterator<ShellC_Element>* charIterator = stringList->getIterator();
+  tIterator<ShellC_Element>* charIterator = completionList->getIterator();
   ShellC_Element* charElem = charIterator->firstElement();
   while (charElem != NULL)
@@ -262 +237 @@
      this->input->addCharacters(adder);
 
-      if (stringList->getSize() == 1)
+      if (completionList->getSize() == 1)
       {
         if ( addBack != NULL )
@@ -280 +255 @@
  * !! The strings MUST NOT be deleted !!
  */
-const tList<ShellC_Element>* ShellCompletion::addToCompleteList(const tList<const char>* inputList, const char* completionBegin)
+bool ShellCompletion::addToCompleteList(const tList<const char>* inputList, const char* completionBegin)
 {
   if (inputList == NULL || completionBegin == NULL)
-    return NULL;
+    return false;
   unsigned int searchLength = strlen(completionBegin);
 
@@ -302 +277 @@
   delete iterator;
 
-  return this->completionList;
+  return true;
 }
 
@@ -311 +286 @@
  * !! The strings MUST NOT be deleted !!
  */
-const tList<ShellC_Element>* ShellCompletion::addToCompleteList(const tList<BaseObject>* inputList, const char* completionBegin)
+bool ShellCompletion::addToCompleteList(const tList<BaseObject>* inputList, const char* completionBegin)
 {
   if (inputList == NULL || completionBegin == NULL)
-    return NULL;
+    return false;
   unsigned int searchLength = strlen(completionBegin);
 
@@ -334 +309 @@
   delete iterator;
 
-  return this->completionList;
+  return true;
 }
 

trunk/src/lib/shell/shell_completion.h

@@ -16 +16 @@
 
 typedef enum {
+  SHELLC_NONE,
   SHELLC_CLASS,
   SHELLC_OBJECT,
   SHELLC_FUNCTION,
   SHELLC_ALIAS,
-} SHELL_CTYPE;
+} SHELLC_TYPE;
 
 struct ShellC_Element{
   const char*     name;     //!<
-  SHELL_CTYPE     type;
+  SHELLC_TYPE     type;
 };
 
@@ -42 +43 @@
   bool functionMatch(const char* functionBegin, long classID, unsigned int* length);
 
-  bool generalComplete(const tList<ShellC_Element>* stringList, const char* begin, const char* displayAs = "%s", const char* addBack = NULL, const char* addFront = NULL);
+  bool generalComplete(const char* begin, const char* displayAs = "%s", const char* addBack = NULL, const char* addFront = NULL);
 
-  const tList<ShellC_Element>* addToCompleteList(const tList<const char>* inputList, const char* completionBegin);
-  const tList<ShellC_Element>* addToCompleteList(const tList<BaseObject>* inputList, const char* completionBegin);
+  bool addToCompleteList(const tList<const char>* inputList, const char* completionBegin);
+  bool addToCompleteList(const tList<BaseObject>* inputList, const char* completionBegin);
   void emptyCompletionList();
 //    const tList<const char>* createCompleteList(const tList<ShellCommandBase>* inputList, const char* completionBegin);