Changeset 5196 in orxonox.OLD for trunk

Timestamp:

Sep 18, 2005, 2:39:39 AM (19 years ago)

Author:

bensch

Message:

orxonox/trunk: ShellCommandAlias should really be completed now

Location:

trunk/src/lib/shell

Files:

• shell_command.cc (modified) (6 diffs)
• shell_command.h (modified) (3 diffs)

trunk/src/lib/shell/shell_command.cc

@@ -41 +41 @@
   this->classID = CL_NULL;
   this->commandList = new tList<ShellCommandBase>;
-  this->aliasList = new tList<ShellCommandAlias>;
 
   ShellCommandClass::commandClassList->add(this);
@@ -91 +90 @@
 bool ShellCommandClass::getCommandListOfAlias(tList<const char>* stringList)
 {
-  if (stringList == NULL)
+  if (stringList == NULL || ShellCommandClass::aliasList == NULL)
     return false;
 
   tIterator<ShellCommandAlias>* iterator = ShellCommandClass::aliasList->getIterator();
-  ShellCommandAlias* elem = iterator->firstElement();
-  while(elem != NULL)
-  {
-    stringList->add(elem->getName());
-    elem = iterator->nextElement();
-  }
-  delete iterator;
-  return true;
+   ShellCommandAlias* elem = iterator->firstElement();
+   while(elem != NULL)
+   {
+     stringList->add(elem->getName());
+     elem = iterator->nextElement();
+   }
+   delete iterator;
+   return true;
 }
 
@@ -126 +125 @@
 
   // unregister all aliases (there should be nothing to do here :))
-  tIterator<ShellCommandAlias>* itAL = ShellCommandClass::aliasList->getIterator();
-  ShellCommandAlias* elemAL = itAL->firstElement();
-  while(elemAL != NULL)
-  {
-    delete elemAL;
-    elemAL = itAL->nextElement();
-  }
-  delete itAL;
-  delete ShellCommandClass::aliasList;
-  ShellCommandClass::aliasList = NULL;
+  if (ShellCommandClass::aliasList != NULL)
+  {
+   tIterator<ShellCommandAlias>* itAL = ShellCommandClass::aliasList->getIterator();
+   ShellCommandAlias* elemAL = itAL->firstElement();
+   while(elemAL != NULL)
+   {
+     delete elemAL;
+     elemAL = itAL->nextElement();
+   }
+   delete itAL;
+   delete ShellCommandClass::aliasList;
+   ShellCommandClass::aliasList = NULL;
+  }
 }
 
@@ -213 +215 @@
   this->setName(commandName);
   this->description = NULL;
+  this->alias = NULL;
 
 //  this->classID = classID;
@@ -267 +270 @@
 {
   delete[] this->parameters;
+  if (this->alias != NULL && ShellCommandClass::aliasList != NULL)
+  {
+    ShellCommandClass::aliasList->remove(this->alias);
+    delete this->alias;
+  }
 }
 
@@ -462 +470 @@
 ShellCommandBase* ShellCommandBase::setAlias(const char* alias)
 {
-  ShellCommandAlias* aliasCMD = new ShellCommandAlias(alias, this);
-  ShellCommandClass::aliasList->add(aliasCMD);
+  if (this == NULL)
+    return NULL;
+
+  if (this->alias != NULL)
+  {
+    PRINTF(2)("not more than one Alias allowed for functions (%s::%s)\n", this->getName(), this->shellClass->getName());
+  }
+  else
+  {
+    if (ShellCommandClass::aliasList == NULL)
+      ShellCommandClass::aliasList = new tList<ShellCommandAlias>;
+
+    ShellCommandAlias* aliasCMD = new ShellCommandAlias(alias, this);
+    ShellCommandClass::aliasList->add(aliasCMD);
+    this->alias = aliasCMD;
+  }
+  return this;
 }
 

trunk/src/lib/shell/shell_command.h

@@ -85 +85 @@
 
     /** @returns the CommandList of the Shell */
-
     static void unregisterCommand(const char* commandName, const char* className);
 
@@ -114 +113 @@
   private:
     ShellCommandClass*               shellClass;                           //!< A Pointer to the Shell-Class this Command belongs to.
+    ShellCommandAlias*               alias;                                //!< An Alias for the Class.
 
     const char*                      description;                          //!< A description for this commnand. (initially NULL). Assigned with (create)->describe("blablabla");
@@ -319 +319 @@
 class ShellCommandAlias
 {
+  friend class ShellCommandBase;
   public:
-    ShellCommandAlias(const char* aliasName, ShellCommandBase* command) { this->aliasName = aliasName; this->command = command; };
-
     const char* getName() const { return this->aliasName; };
     ShellCommandBase* getCommand() const { return this->command; };
+
+  private:
+    ShellCommandAlias(const char* aliasName, ShellCommandBase* command) { this->aliasName = aliasName; this->command = command; };
+
   private:
     const char*         aliasName;