Changeset 5785 for code/branches/core5/src/modules

Timestamp:

Sep 25, 2009, 12:54:12 AM (15 years ago)

Author:

landauf

Message:

Removed end-iterator-safety from Iterator and ObjectListIterator. This means, when you reach end(), don't use *it anymore (this returned 0 in the past, now you'll get a segfault).
Changed ClassTreeMask and Radar accordingly.

Also, please always use "for (…) { (it++)→function() }" instead of "for (…; ++it) { it→function() }" if there's a chance function() destroys the object pointed by the iterator. Our objectlists are deletionsafe, but you'll encounter strange problems like overleaped elements and run-over-end() situations if you use the second pattern and don't doublecheck the iterator in the loop.
Changed GSRoot accordingly.

File:

• code/branches/core5/src/modules/gamestates/GSRoot.cc (modified) (2 diffs)

code/branches/core5/src/modules/gamestates/GSRoot.cc

@@ -111 +111 @@
         }
 
-        for (ObjectList<TimerBase>::iterator it = ObjectList<TimerBase>::begin(); it; ++it)
-            it->tick(time);
+        for (ObjectList<TimerBase>::iterator it = ObjectList<TimerBase>::begin(); it; )
+            (it++)->tick(time);
 
         /*** HACK *** HACK ***/
@@ -122 +122 @@
             leveldt = 0.0f;
         }
-        for (ObjectList<Tickable>::iterator it = ObjectList<Tickable>::begin(); it; ++it)
-            it->tick(leveldt * this->timeFactor_);
+        for (ObjectList<Tickable>::iterator it = ObjectList<Tickable>::begin(); it; )
+            (it++)->tick(leveldt * this->timeFactor_);
         /*** HACK *** HACK ***/
     }