Changeset 5963

Timestamp:

Oct 18, 2009, 11:39:32 PM (15 years ago)

Author:

rgrieder

Message:

Improved Visual Studio IntelliSense (tool that suggests function names etc.) performance by excluding all external libraries (headers used in our projects still get parsed) and the compilations (double work otherwise).
Curiously there is no official switch to disable IntelliSense. There's only a local and unofficial version that deals with removing a particular DLL.
However if Microsoft dares to create bugs, we dare to exploit them: Specifying "-Zm1000" instead of "/Zm1000" as compile flag messes with IntelliSense. It once took me half a day to figure that out since the causality between that and "IntelliSense is not working at all for any project" is rather unexpected

Location:

code/trunk/cmake

Files:

• CompilerConfigMSVC.cmake (modified) (1 diff)
• SourceFileUtilities.cmake (modified) (1 diff)
• TargetUtilities.cmake (modified) (3 diffs)

code/trunk/cmake/CompilerConfigMSVC.cmake

@@ -68 +68 @@
 ADD_COMPILER_FLAGS("-D__WIN32__ -D_WIN32"      CACHE)
 ADD_COMPILER_FLAGS("-D_CRT_SECURE_NO_WARNINGS" CACHE)
+
+# We need this flag to hack-disable IntelliSense for certain files/projects
+# Our precompiled headers should not be larger than 50MB anyway
+# because otherwise they get rendered useless due to too many file fragments
+REMOVE_COMPILER_FLAGS("-Zm1000" CACHE)
 
 # Overwrite CMake default flags here.

code/trunk/cmake/SourceFileUtilities.cmake

@@ -48 +48 @@
       ENDIF()
       IF(NOT DISABLE_COMPILATIONS)
+        SET(_compilation_file ${CMAKE_CURRENT_BINARY_DIR}/${_compilation_name})
         SET(_include_string)
         FOREACH(_file2 ${_compilation})
           SET(_include_string "${_include_string}#include \"${_file2}\"\n")
         ENDFOREACH(_file2)
-        IF(EXISTS ${CMAKE_CURRENT_BINARY_DIR}/${_compilation_name})
-          FILE(READ ${CMAKE_CURRENT_BINARY_DIR}/${_compilation_name} _include_string_file)
+        IF(EXISTS )
+          FILE(READ ${_compilation_file} _include_string_file)
         ENDIF()
         IF(NOT _include_string STREQUAL "${_include_string_file}")
-          FILE(WRITE ${CMAKE_CURRENT_BINARY_DIR}/${_compilation_name} "${_include_string}")
+          FILE(WRITE ${_compilation_file} "${_include_string}")
         ENDIF()
-        LIST(APPEND _fullpath_sources ${CMAKE_CURRENT_BINARY_DIR}/${_compilation_name})
+        LIST(APPEND _fullpath_sources ${_compilation_file})
+        # MSVC hack that excludes the compilations from the intellisense database
+        # (There is a bug with the "-" instead of "/". Only works for "Zm#" argument)
+        IF(MSVC)
+          SET_SOURCE_FILES_PROPERTIES(${_compilation_file} PROPERTIES COMPILE_FLAGS "-Zm1000")
+        ENDIF()
       ENDIF()
       SET(_compilation_name)

code/trunk/cmake/TargetUtilities.cmake

@@ -181 +181 @@
   ENDFOREACH(_file)
 
+
+
   # Add the library/executable
   IF("${_target_type}" STREQUAL "LIBRARY")
@@ -190 +192 @@
   ENDIF()
 
+
+
   # Change library prefix to "lib"
   IF(MSVC AND ${_target_type} STREQUAL "LIBRARY")
@@ -195 +199 @@
       PREFIX "lib"
     )
+  ENDIF()
+
+  # MSVC hack to exclude external library sources from the intellisense database
+  # (IntelliSense stops working when adding "-Zm1000" as compile flag. "/Zm1000"
+  # would not work because of the slash)
+  IF(_arg_ORXONOX_EXTERNAL AND MSVC)
+    SET_TARGET_PROPERTIES(${_target_name} PROPERTIES COMPILE_FLAGS "-Zm1000")
   ENDIF()