Changeset 6218 for code/branches/presentation2/src/libraries

Timestamp:

Dec 2, 2009, 10:20:37 PM (15 years ago)

Author:

rgrieder

Message:

Fixed at least 8 unitialised value problems though not all of them are problematic. Still, the values are being used and some condition depends on it.

Location:

code/branches/presentation2/src/libraries

Files:

• core/ConfigValueContainer.h (modified) (2 diffs)
• tools/ParticleInterface.cc (modified) (2 diffs)
• tools/Shader.cc (modified) (1 diff)

code/branches/presentation2/src/libraries/core/ConfigValueContainer.h

@@ -146 +146 @@
                 if ((this->callback_ && object) || this->bContainerIsNew_)
                 {
-                    if (this->bContainerIsNew_)
-                        this->bContainerIsNew_ = false;
-
                     T temp = *value;
                     this->value_.getValue(value);
-                    if ((*value) != temp)
+                    if (this->bContainerIsNew_ || (*value) != temp)
                     {
                         if (this->callback_ && object)
@@ -158 +155 @@
                             this->bDoInitialCallback_ = true;
                     }
+
+                    if (this->bContainerIsNew_)
+                        this->bContainerIsNew_ = false;
                 }
                 else

code/branches/presentation2/src/libraries/tools/ParticleInterface.cc

@@ -64 +64 @@
         this->bAllowedByLOD_ = true;
         this->speedFactor_ = 1.0f;
+
+        this->setDetailLevel(static_cast<unsigned int>(detaillevel));
 
         this->setConfigValues();
@@ -80 +82 @@
             }
         }
-
-        this->setDetailLevel(static_cast<unsigned int>(detaillevel));
     }
 

code/branches/presentation2/src/libraries/tools/Shader.cc

@@ -79 +79 @@
     Shader::~Shader()
     {
-
-        if (this->bLoadCompositor_ && this->compositorInstance_)
+        if (this->compositorInstance_ && this->bLoadCompositor_)
         {
             Ogre::Viewport* viewport = GraphicsManager::getInstance().getViewport();