Changeset 6383 for code

Timestamp:

Dec 19, 2009, 10:14:08 PM (15 years ago)

Author:

rgrieder

Message:

Fixed a major sound issue: The state gets reset to 'Stopped' when the sound has finished playing (unless in loop mode of course).

Location:

code/branches/presentation2/src

Files:

• modules/weapons/projectiles/Rocket.cc (modified) (1 diff)
• orxonox/sound/BaseSound.cc (modified) (1 diff)
• orxonox/sound/SoundManager.cc (modified) (5 diffs)
• orxonox/sound/SoundManager.h (modified) (2 diffs)

code/branches/presentation2/src/modules/weapons/projectiles/Rocket.cc

@@ -115 +115 @@
         {
             if (GameMode::isMaster() && this->player_)
-            {
                 this->player_->stopTemporaryControl();
-            }
+
             if ( this->defSndWpnEngine_ )
-            {
-                if ( this->defSndWpnEngine_->isPlaying() )
-                    this->defSndWpnEngine_->stop();
                 this->defSndWpnEngine_->destroy();
-            }
+
             if ( this->defSndWpnLaunch_ )
-            {
-                if ( this->defSndWpnLaunch_->isPlaying())
-                    this->defSndWpnLaunch_->stop();
                 this->defSndWpnLaunch_->destroy();
-            }
         }
     }

code/branches/presentation2/src/orxonox/sound/BaseSound.cc

@@ -77 +77 @@
             if (!alIsSource(this->audioSource_))
             {
-                this->audioSource_ = SoundManager::getInstance().getSoundSource();
+                this->audioSource_ = SoundManager::getInstance().getSoundSource(this);
                 if (!alIsSource(this->audioSource_))
                     return;

code/branches/presentation2/src/orxonox/sound/SoundManager.cc

@@ -145 +145 @@
         alGenSources(1, &source);
         if (!alGetError() && alIsSource(source))
-            this->soundSources_.push_back(source);
+            this->availableSoundSources_.push_back(source);
         else
             ThrowException(InitialisationFailed, "Sound Error: Could not even create a single source");
@@ -153 +153 @@
         while (alIsSource(source) && !alGetError() && count <= this->maxSources_)
         {
-            this->soundSources_.push_back(source);
+            this->availableSoundSources_.push_back(source);
             alGenSources(1, &source);
             ++count;
@@ -195 +195 @@
     {
         this->processCrossFading(time.getDeltaTime());
+
+        // Check whether a sound object has stopped playing
+        for (unsigned int i = 0; i < this->usedSoundSources_.size(); ++i)
+        {
+            ALint state;
+            alGetSourcei(this->usedSoundSources_[i].first, AL_SOURCE_STATE, &state);
+            if (state == AL_STOPPED)
+            {
+                this->usedSoundSources_[i].second->stop();
+                --i;
+            }
+        }
     }
 
@@ -536 +548 @@
     }
 
-    ALuint SoundManager::getSoundSource()
-    {
-        if (!this->soundSources_.empty())
-        {
-            ALuint source = this->soundSources_.back();
-            this->soundSources_.pop_back();
+    ALuint SoundManager::getSoundSource(BaseSound* object)
+    {
+        if (!this->availableSoundSources_.empty())
+        {
+            ALuint source = this->availableSoundSources_.back();
+            this->availableSoundSources_.pop_back();
+            this->usedSoundSources_.push_back(std::make_pair(source, object));
             return source;
         }
@@ -556 +569 @@
     {
 #ifndef NDEBUG
-        for (std::vector<ALuint>::const_iterator it = this->soundSources_.begin(); it != this->soundSources_.end(); ++it)
+        for (std::vector<ALuint>::const_iterator it = this->availableSoundSources_.begin(); it != this->availableSoundSources_.end(); ++it)
             assert((*it) != source);
 #endif
-        this->soundSources_.push_back(source);
+        this->availableSoundSources_.push_back(source);
+        for (std::vector<std::pair<ALuint, BaseSound*> >::iterator it = this->usedSoundSources_.begin();
+            it != this->usedSoundSources_.end(); ++it)
+        {
+            if (it->first == source)
+            {
+                this->usedSoundSources_.erase(it);
+                break;
+            }
+        }
     }
 }

code/branches/presentation2/src/orxonox/sound/SoundManager.h

@@ -102 +102 @@
         void releaseSoundBuffer(const shared_ptr<SoundBuffer>& buffer, bool bPoolBuffer);
 
-        ALuint getSoundSource();
+        ALuint getSoundSource(BaseSound* object);
         void releaseSoundSource(ALuint source);
 
@@ -147 +147 @@
         // Sound source related
         unsigned int maxSources_;
-        std::vector<ALuint> soundSources_;
+        std::vector<ALuint> availableSoundSources_;
+        std::vector<std::pair<ALuint, BaseSound*> > usedSoundSources_;
 
         static SoundManager* singletonPtr_s;