Changeset 6480

Timestamp:

Mar 7, 2010, 2:05:05 PM (15 years ago)

Author:

dafrick

Message:

Simplification in creation of PickupIdentifier.

Location:

code/branches/pickup3/src

Files:

• modules/pickup/Pickup.cc (modified) (1 diff)
• modules/pickup/PickupCollection.cc (modified) (2 diffs)
• modules/pickup/PickupCollectionIdentifier.cc (modified) (1 diff)
• modules/pickup/PickupCollectionIdentifier.h (modified) (1 diff)
• modules/pickup/items/HealthPickup.cc (modified) (1 diff)
• orxonox/interfaces/Pickupable.cc (modified) (1 diff)
• orxonox/pickup/PickupIdentifier.cc (modified) (4 diffs)
• orxonox/pickup/PickupIdentifier.h (modified) (1 diff)

code/branches/pickup3/src/modules/pickup/Pickup.cc

@@ -72 +72 @@
     */
     void Pickup::initializeIdentifier(void)
-    {
-        //TODO: Check whether this could not be done in the Constructor if Pickupable. Would be much more convenient.
-        this->pickupIdentifier_->addClass(this->getIdentifier());
-        
+    {        
         //TODO: Works?
         std::string val1 = this->getActivationType();

code/branches/pickup3/src/modules/pickup/PickupCollection.cc

@@ -53 +53 @@
         RegisterObject(PickupCollection);
         
-        this->pickupCollectionIdentifier_ = new PickupCollectionIdentifier();
+        this->pickupCollectionIdentifier_ = new PickupCollectionIdentifier(this);
     }
     
@@ -85 +85 @@
     void PickupCollection::initializeIdentifier(void)
     {
-        this->pickupCollectionIdentifier_->addClass(this->getIdentifier());
-        
         for(std::vector<Pickupable*>::iterator it = this->pickups_.begin(); it != this->pickups_.end(); it++)
         {

code/branches/pickup3/src/modules/pickup/PickupCollectionIdentifier.cc

@@ -34 +34 @@
 {
     
-    PickupCollectionIdentifier::PickupCollectionIdentifier(void)
+    PickupCollectionIdentifier::PickupCollectionIdentifier(Pickupable* pickup) : PickupIdentifier(pickup)
     {
         RegisterObject(PickupCollectionIdentifier);

code/branches/pickup3/src/modules/pickup/PickupCollectionIdentifier.h

@@ -42 +42 @@
         
         public:
-            PickupCollectionIdentifier(void);
+            PickupCollectionIdentifier(Pickupable* pickup);
             ~PickupCollectionIdentifier();
             

code/branches/pickup3/src/modules/pickup/items/HealthPickup.cc

@@ -88 +88 @@
     void HealthPickup::initializeIdentifier(void)
     {
-        this->pickupIdentifier_->addClass(this->getIdentifier());
-        
         std::stringstream stream;
         stream << this->getHealth();

code/branches/pickup3/src/orxonox/interfaces/Pickupable.cc

@@ -55 +55 @@
         this->carrier_ = NULL;
         
-        this->pickupIdentifier_ = new PickupIdentifier();
+        this->pickupIdentifier_ = new PickupIdentifier(this);
     }
     

code/branches/pickup3/src/orxonox/pickup/PickupIdentifier.cc

@@ -30 +30 @@
 
 #include "core/CoreIncludes.h"
+#include "interfaces/Pickupable.h"
 
 namespace orxonox
@@ -38 +39 @@
         Constructor. Registers the object and initializes member variables.
     */
-    PickupIdentifier::PickupIdentifier()
+    PickupIdentifier::PickupIdentifier(Pickupable* pickup)
     {
         RegisterRootObject(PickupIdentifier);
         
-        this->classIdentifier_ = NULL;
+        this->pickup_ = pickup;
     }
     
@@ -61 +62 @@
     {
         //! If the classIdentifiers are not the same (meaning the PickupIdentifiers identify different classes), the obviously the two Pickupables identified by the PickupIdentifiers cannot be the same. An ordering is established through the alphabetical ordering of the respective classnames.
-        if(!identifier->classIdentifier_->isExactlyA(this->classIdentifier_))
-            return this->classIdentifier_->getName().compare(identifier->classIdentifier_->getName());
+        if(!identifier->pickup_->getIdentifier()->isExactlyA(this->pickup_->getIdentifier()))
+            return this->pickup_->getIdentifier()->getName().compare(identifier->pickup_->getIdentifier()->getName());
         
         //! If the class is the same for both PickupIdentifiers we go on to check the parameters of the class.
@@ -86 +87 @@
             
         return false;
-    }
-    
-    /**
-    @brief
-        Add the class of the Pickupable to its PickupIdentifier.
-    @param identifier
-        A pointer to the Identifier of the class.
-    */
-    void PickupIdentifier::addClass(Identifier* identifier)
-    {
-        this->classIdentifier_ = identifier;
     }
     

code/branches/pickup3/src/orxonox/pickup/PickupIdentifier.h

@@ -54 +54 @@
         
         public:
-            PickupIdentifier(void); //!< Constructor.
+            PickupIdentifier(Pickupable* pickup); //!< Constructor.
             ~PickupIdentifier(); //!< Destructor.
             
             virtual int compare(const PickupIdentifier* identifier) const; //!< Compares two PickupIdentifiers and returns 0 if a == b, <0 if a < b and >0 if a > b for a.compare(b).
             
-            void addClass(Identifier* identifier); //!< Add the class of the Pickupable to its PickupIdentifier.
             bool addParameter(std::string & name, std::string & value); //!< Add a parameter to the PickupIdentifier.
             
         private:
-            Identifier* classIdentifier_; //!< The Identifier of the class.
+            Pickupable* pickup_; //!< The Pickupable the PickupIdentififer is for.
             std::map<std::string, std::string> parameters_; //!< The parameters identifying the type of the pickup beyond the class.