Changeset 7174 for code/trunk/src/orxonox

Timestamp:

Aug 18, 2010, 12:08:05 AM (14 years ago)

Author:

rgrieder

Message:

Only catch exceptions you actually expect. And rethrow unknown exceptions ("…" can also catch internal Microsoft exceptions like floating point exception).

Location:

code/trunk/src/orxonox

Files:

• graphics/ParticleEmitter.cc (modified) (1 diff)
• sound/SoundManager.cc (modified) (1 diff)
• worldentities/BigExplosion.cc (modified) (1 diff)
• worldentities/ExplosionChunk.cc (modified) (1 diff)

code/trunk/src/orxonox/graphics/ParticleEmitter.cc

@@ -114 +114 @@
                 this->particles_->setEnabled(this->isActive());
             }
-            catch (...)
+            catch (const std::exception& ex)
             {
                 COUT(1) << "Error: Couln't load particle effect \"" << this->source_ << "\" because:" << std::endl
-                        << Exception::handleMessage() << std::endl;
+                        << ex.what() << std::endl;
             }
         }

code/trunk/src/orxonox/sound/SoundManager.cc

@@ -521 +521 @@
                 buffer.reset(new SoundBuffer(filename, this->effectsPool_.end()));
             }
-            catch (...)
-            {
-                COUT(1) << Exception::handleMessage() << std::endl;
+            catch (const std::exception& ex)
+            {
+                COUT(1) << ex.what() << std::endl;
                 return buffer;
             }

code/trunk/src/orxonox/worldentities/BigExplosion.cc

@@ -72 +72 @@
                 this->init();
             }
-            catch (...)
-            {
-                COUT(1) << "Error: Couln't load particle effect in BigExplosion: " << Exception::handleMessage() << std::endl;
+            catch (const std::exception& ex)
+            {
+                COUT(1) << "Error: Couln't load particle effect in BigExplosion: " << ex.what() << std::endl;
                 this->initZero();
             }

code/trunk/src/orxonox/worldentities/ExplosionChunk.cc

@@ -59 +59 @@
                 this->attachOgreObject(this->smoke_->getParticleSystem());
             }
-            catch (...)
+            catch (const std::exception& ex)
             {
-                COUT(1) << "Error: Couln't load particle effect in ExplosionChunk: " << Exception::handleMessage() << std::endl;
+                COUT(1) << "Error: Couln't load particle effect in ExplosionChunk: " << ex.what() << std::endl;
                 this->fire_ = 0;
                 this->smoke_ = 0;