Changeset 7208 in orxonox.OLD for branches/std/src/world_entities

Timestamp:

Mar 10, 2006, 1:56:40 AM (19 years ago)

Author:

bensch

Message:

orxonox/std: less evil

Location:

branches/std/src/world_entities

Files:

• movie_entity.cc (modified) (1 diff)
• movie_entity.h (modified) (1 diff)
• skybox.cc (modified) (8 diffs)
• skybox.h (modified) (3 diffs)

branches/std/src/world_entities/movie_entity.cc

@@ -74 +74 @@
 }
 
-void MovieEntity::loadMovie(const char* filename)
+void MovieEntity::loadMovie(const std::string& filename)
 {
   if(media_container->loadMedia(filename))

branches/std/src/world_entities/movie_entity.h

@@ -37 +37 @@
     virtual void loadParams(const TiXmlElement* root);
 
-    void loadMovie(const char* filename);
+    void loadMovie(const std::string& filename);
     void setAxis(float axis);
     void setRotation(float rotation);

branches/std/src/world_entities/skybox.cc

@@ -38 +38 @@
  * @param fileName the file to take as input for the SkyBox
 */
-SkyBox::SkyBox(const char* fileName)
+SkyBox::SkyBox(const std::string& fileName)
 {
   this->preInit();
-  if (fileName)
+  if (!fileName.empty())
     this->setTextureAndType(fileName, ".jpg");
   this->postInit();
@@ -89 +89 @@
   this->setParentMode(PNODE_MOVEMENT);
 
-  this->textureName = NULL;
+  this->textureName = "";
 }
 
@@ -106 +106 @@
   for (int i = 0; i < 6; i++)
   {
-    if( this->material[i])
+    if (this->material[i])
       delete this->material[i];
-    if( this->cubeTexture[i])
+    if (this->cubeTexture[i])
       ResourceManager::getInstance()->unload(this->cubeTexture[i]);
   }
 }
+
+void SkyBox::setTexture(const std::string& name)
+{
+  this->textureName = name;
+  this->setTextureAndType (name, "jpg");
+};
+
 
 /**
@@ -122 +129 @@
                "skybox_right.jpg", "skybox_front.jpg", "skybox_back.jpg");
 */
-void SkyBox::setTextureAndType(const char* name, const char* extension)
-{
-  char* top    = new char[strlen(name)+strlen(extension)+ 10];
-  char* bottom = new char[strlen(name)+strlen(extension)+ 10];
-  char* left   = new char[strlen(name)+strlen(extension)+ 10];
-  char* right  = new char[strlen(name)+strlen(extension)+ 10];
-  char* front  = new char[strlen(name)+strlen(extension)+ 10];
-  char* back   = new char[strlen(name)+strlen(extension)+ 10];
-
-  sprintf(top, "%s_top.%s", name, extension);
-  sprintf(bottom, "%s_bottom.%s", name, extension);
-  sprintf(left, "%s_left.%s", name, extension);
-  sprintf(right, "%s_right.%s", name, extension);
-  sprintf(front, "%s_front.%s", name, extension);
-  sprintf(back, "%s_back.%s", name, extension);
+void SkyBox::setTextureAndType(const std::string& name, const std::string& extension)
+{
+  std::string top = name + "_top." + extension;
+  std::string bottom = name + "_bottom." + extension;
+  std::string left = name + "_left." + extension;
+  std::string right = name + "_right." + extension;
+  std::string front = name + "_front." + extension;
+  std::string back = name + "_back." + extension;
 
   this->setTextures(top, bottom, left, right, front, back);
-
-  // deleted alocated memory of this function
-  delete []top;
-  delete []bottom;
-  delete []left;
-  delete []right;
-  delete []front;
-  delete []back;
 }
 
@@ -158 +150 @@
  * @param back the back texture.
 */
-void SkyBox::setTextures(const char* top, const char* bottom, const char* left,
-                          const char* right, const char* front, const char* back)
+void SkyBox::setTextures(const std::string& top, const std::string& bottom, const std::string& left,
+                          const std::string& right, const std::string& front, const std::string& back)
 {
   this->material[0]->setDiffuseMap(top);
@@ -171 +163 @@
 }
 
-void SkyBox::loadCubeMapTextures(const char* top, const char* bottom, const char* left,
-                                  const char* right, const char* front, const char* back)
+void SkyBox::loadCubeMapTextures(const std::string& top, const std::string& bottom, const std::string& left,
+                                  const std::string& right, const std::string& front, const std::string& back)
 {
   this->cubeTexture[0] = (Texture*)ResourceManager::getInstance()->load(top, RP_LEVEL, IMAGE, GL_TEXTURE_CUBE_MAP_POSITIVE_Y_EXT);
@@ -304 +296 @@
 
   SYNCHELP_READ_FLOAT( size, NWT_SB_SIZE );
-  if ( textureName )
+  if ( !this->textureName.empty() )
   {
-    delete[] textureName;
-    textureName = NULL;
+    textureName = "";
   }
-  SYNCHELP_READ_STRINGM( textureName, NWT_SB_TEXTURENAME );
+  char* texName;
+  SYNCHELP_READ_STRINGM( texName, NWT_SB_TEXTURENAME );
 
   this->setSize( size );
-  this->setTextureAndType( textureName, "jpg" );
+  this->setTextureAndType( texName, "jpg" );
   this->rebuild();
 
@@ -338 +330 @@
 
     SYNCHELP_WRITE_FLOAT(this->size, NWT_SB_SIZE);
-    SYNCHELP_WRITE_STRING(this->textureName, NWT_SB_TEXTURENAME);
+    SYNCHELP_WRITE_STRING(this->textureName.c_str(), NWT_SB_TEXTURENAME);
 
     return SYNCHELP_WRITE_N;

branches/std/src/world_entities/skybox.h

@@ -28 +28 @@
 {
  public:
-  SkyBox(const char* fileName = NULL);
+  SkyBox(const std::string& fileName = "");
   SkyBox(const TiXmlElement* root);
 
@@ -44 +44 @@
   void setSize(float size);
   /** assumes jpg as input-format */
-  void setTexture(const char* name) { if (textureName) delete[] textureName; textureName = new char[strlen(name)+1]; strcpy(textureName, name); this->setTextureAndType (name, "jpg"); };
+  void setTexture(const std::string& name);
 
-  void setTextureAndType(const char* name, const char* extension);
-  void setTextures(const char* top, const char* bottom, const char* left,
-                   const char* right, const char* front, const char* back);
+  void setTextureAndType(const std::string& name, const std::string& extension);
+  void setTextures(const std::string& top, const std::string& bottom, const std::string& left,
+                   const std::string& right, const std::string& front, const std::string& back);
 
-  void loadCubeMapTextures(const char* top, const char* bottom, const char* left,
-                           const char* right, const char* front, const char* back);
+  void loadCubeMapTextures(const std::string& top, const std::string& bottom, const std::string& left,
+                           const std::string& right, const std::string& front, const std::string& back);
 
   GLuint getTexture(SKY_SIDE side) const { return (this->material[side]) ? this->material[side]->getDiffuseTexture(): 0; };
@@ -71 +71 @@
   float           size;            //!< Size of the SkyBox. This should match the frustum maximum range.
   float           textureSize;     //!< this is the length of a texture (assumes a square texture)
-  char*           textureName;     //!< Name of the Texture
+  std::string     textureName;     //!< Name of the Texture
 
 };