Changeset 7457 for code/trunk/src/libraries/util

Timestamp:

Sep 16, 2010, 1:45:08 PM (14 years ago)

Author:

landauf

Message:

show file name and line number in the call stack (works only with msvc)
hack-fix for wrong call stack when calling some "noreturn" functions (e.g. _assert())
some cleanup

Location:

code/trunk/src/libraries/util

Files:

• SignalHandler.cc (modified) (6 diffs)
• SignalHandler.h (modified) (2 diffs)

code/trunk/src/libraries/util/SignalHandler.cc

@@ -37 +37 @@
 #include <cstdlib>
 #include <cstring>
+
 #include "Debug.h"
 
@@ -344 +345 @@
 
 #ifdef ORXONOX_COMPILER_GCC
+/// Overwrite the original abort() function in MinGW to enable a break point.
 _UtilExport void __cdecl abort()
 {
@@ -352 +354 @@
 }
 
+/// Overwrite the original _abort() function in MinGW to enable a break point.
 _UtilExport void __cdecl _assert(const char* expression, const char* file, int line)
 {
@@ -391 +394 @@
             // Install the unhandled exception filter function
             this->prevExceptionFilter_ = SetUnhandledExceptionFilter(&SignalHandler::exceptionFilter);
-
-//            std::set_terminate(&myterminate);
-/*
-#ifdef ORXONOX_COMPILER_GCC
-            MODULEENTRY32 module;
-            memset(&module, 0, sizeof(MODULEENTRY32));
-            module.dwSize = sizeof(MODULEENTRY32);
-
-            HANDLE snapshot = CreateToolhelp32Snapshot(TH32CS_SNAPMODULE, 0);
-
-            BOOL result = Module32First(snapshot, &module);
-
-            COUT(0) << SignalHandler::pointerToString((unsigned)_assert) << std::endl;
-
-            while (result)
-            {
-                COUT(0) << module.szModule << std::endl;
-                COUT(0) << SignalHandler::pointerToString((unsigned)module.modBaseAddr) << " / " << SignalHandler::pointerToString(*module.modBaseAddr) << std::endl;;
-
-                FARPROC procAssert = GetProcAddress(module.hModule, "__ZSt13set_terminatePFvvE");
-                if (procAssert)
-                {
-                    COUT(0) << "yes1 --------------------------------------------------------" << std::endl;
-                    COUT(0) << SignalHandler::pointerToString((unsigned)procAssert) << std::endl;
-                    // *(volatile unsigned*)procAssert = 0xcc;
-                }
-
-                result = Module32Next(snapshot, &module);
-            }
-
-//            *(volatile unsigned*)abort = 0xcc;
-//            *(volatile unsigned*)_assert = 0xcc;
-#endif
-*/
         }
     }
@@ -606 +575 @@
 
             // Get the symbol information from the address of the instruction pointer register:
-            if
+            bool bCorrected = false;
+            BOOL result = SymFromAddr
             (
-                SymFromAddr
+                GetCurrentProcess() ,   // Process to get symbol information for
+                frame.AddrPC.Offset ,   // Address to get symbol for: instruction pointer register
+                &displacement       ,   // Displacement from the beginning of the symbol
+                symbol                  // Where to save the symbol
+            );
+
+            // If the symbol was found, but the displacement is 0, we likely got the wrong symbol - decrease the program counter and try again
+            if (result && displacement == 0)
+            {
+                bCorrected = true;
+                result = SymFromAddr
                 (
-                    GetCurrentProcess() ,   // Process to get symbol information for
-                    frame.AddrPC.Offset ,   // Address to get symbol for: instruction pointer register
-                    &displacement       ,   // Displacement from the beginning of the symbol
-                    symbol                  // Where to save the symbol
-                )
-            )
+                    GetCurrentProcess()     ,
+                    frame.AddrPC.Offset - 1 ,
+                    &displacement           ,
+                    symbol
+                );
+            }
+
+            // Display the function name + offset
+            if (result)
             {
                 // Add the name of the function to the function list:
@@ -635 +618 @@
 
                 output += " +" + SignalHandler::pointerToString(displacement, false);
+                if (bCorrected)
+                    output += " (?)";
             }
 
-/*
-            IMAGEHLP_MODULE64 module;
-            memset(&module, 0, sizeof(IMAGEHLP_MODULE64));
-            module.SizeOfStruct = sizeof(IMAGEHLP_MODULE64);
+            output += "\n";
+
+            // Get the file name and line number
+            IMAGEHLP_LINE64 line;
+            memset(&line, 0, sizeof(IMAGEHLP_LINE64));
+            line.SizeOfStruct = sizeof(IMAGEHLP_LINE64);
+
+            DWORD displacement2 = 0;
 
             if
             (
-                SymGetModuleInfo64
+                SymGetLineFromAddr64
                 (
                     GetCurrentProcess(),
-                    frame.AddrPC.Offset,
-                    &module
+                    frame.AddrPC.Offset - bCorrected ? 1 : 0,
+                    &displacement2,
+                    &line
                 )
             )
             {
-                IMAGEHLP_LINE64 line;
-                memset(&line, 0, sizeof(IMAGEHLP_LINE64));
-                line.SizeOfStruct = sizeof(IMAGEHLP_LINE64);
-
-                DWORD displacement2 = displacement;
-
-                if
-                (
-                    SymGetLineFromAddr64
-                    (
-                        GetCurrentProcess(),
-                        frame.AddrPC.Offset,
-                        &displacement2,
-                        &line
-                    )
-                )
-                {
-                    output += "\n";
-                    output += "               ";
-                    output += line.FileName;
-                    output += ":";
-                    output += multi_cast<std::string>(line.LineNumber);
-                }
+                output += "               ";
+                output += line.FileName;
+                output += ":";
+                output += multi_cast<std::string>(line.LineNumber);
+                output += "\n";
             }
-*/
-            output += "\n";
         }
 

code/trunk/src/libraries/util/SignalHandler.h

@@ -40 +40 @@
 #include <cassert>
 #include <string>
+
 #include "Singleton.h"
 #include "SpecialConfig.h"
@@ -72 +73 @@
     {
         friend class Singleton<SignalHandler>;
-    public:
-        SignalHandler()  { }
-        ~SignalHandler() { }
 
-        void registerCallback( SignalCallback cb, void * someData );
+        public:
+            void registerCallback( SignalCallback cb, void * someData );
 
-        void doCatch( const std::string & appName, const std::string & filename );
-        void dontCatch();
+            void doCatch( const std::string & appName, const std::string & filename );
+            void dontCatch();
 
-    private:
-        static void sigHandler( int sig );
+        private:
+            static void sigHandler( int sig );
 
-        void catchSignal( int sig );
-        SignalRecList sigRecList;
+            void catchSignal( int sig );
+            SignalRecList sigRecList;
 
-        SignalCallbackList callbackList;
+            SignalCallbackList callbackList;
 
-        static SignalHandler* singletonPtr_s;
+            static SignalHandler* singletonPtr_s;
 
-        std::string appName;
-        std::string filename;
+            std::string appName;
+            std::string filename;
     };
 }