Changeset 7756

Timestamp:

Dec 11, 2010, 9:07:55 PM (14 years ago)

Author:

smerkli

Message:

started implementing server pings, but need a change to masterservercomm soon.

Location:

code/branches/presentation/src/libraries/network

Files:

• MasterServer.cc (modified) (2 diffs)
• MasterServerComm.cc (modified) (8 diffs)
• MasterServerComm.h (modified) (1 diff)
• MasterServerProtocol.h (modified) (3 diffs)
• Server.cc (modified) (3 diffs)
• WANDiscovery.cc (modified) (1 diff)

code/branches/presentation/src/libraries/network/MasterServer.cc

@@ -185 +185 @@
           packet::ServerInformation( event ).getServerIP() << "\n";
       }
+
+      /* TODO add hook for disconnect here */
     }
     else if( !strncmp( (char *)event->packet->data, MSPROTO_CLIENT, 
@@ -218 +220 @@
     }
 
+    /* TODO schedule pings for servers somewhere here */
     
     /* create an iterator for the loop */

code/branches/presentation/src/libraries/network/MasterServerComm.cc

@@ -38 +38 @@
   } 
 
-
   int MasterServerComm::initialize()
   {
@@ -52 +51 @@
     /* install atexit handler for enet */
     atexit( enet_deinitialize );
-
 
     /* initiate the client */
@@ -87 +85 @@
     if (this->peer == NULL )
     { COUT(2) << "ERROR: No available peers for initiating an ENet connection.\n";
-    return -1;
+      return -1;
     }
 
@@ -102 +100 @@
     }
 
-    return 0;
-  }
-
-  int MasterServerComm::pollForReply( int (*callback)( char*, ENetEvent* ) )
+    /* all fine */
+    return 0;
+  }
+
+  /* NOTE this is to be reimplemented soon to return 
+   * a structure containing 
+   * - addrconv
+   * - the event
+   * so we can also make callbacks from objects
+   */
+  int MasterServerComm::pollForReply( int (*callback)( char*, ENetEvent* ),
+    int delayms )
   { 
     /* see whether anything happened */
@@ -117 +123 @@
     /* enet_host_service returns 0 if no event occured */
     /* just newly set below test to >0 from >= 0, to be tested */
-    if( enet_host_service( this->client, this->event, 1000 ) > 0 )
+    if( enet_host_service( this->client, this->event, delayms ) > 0 )
     { 
       /* check what type of event it is and react accordingly */
@@ -140 +146 @@
 
           /* DEBUG */
-          COUT(3) << "A packet of length " << this->event->packet->dataLength 
+          COUT(3) << "MasterServer Debug: A packet of length " 
+            << this->event->packet->dataLength 
             << " containing " << this->event->packet->data
             << " was received from " << addrconv 
             << " on channel " << this->event->channelID;
-          //printf( "A packet of length %u containing %s was "
-            //"received from %s on channel %u.\n",
-            //this->event->packet->dataLength,
-            //this->event->packet->data,
-            //addrconv,
-            //this->event->channelID );
           /* END DEBUG */
 
@@ -156 +157 @@
             retval = (*callback)( addrconv, (this->event) );
 
+          /* clean up */
           enet_packet_destroy( event->packet );
-          if( addrconv ) free( addrconv );
+          if( addrconv ) 
+            free( addrconv );
+
           break;
         default: break;
@@ -211 +215 @@
 
 }
-
-
-/* DON'T DELETE THIS I MIGHT NEED IT AGAIN -smerkli */
-/* not needed anymore, only here for testing purposes */
-/*
-//[> sample callback to output debugging info. <]
-//int callb( char *addr, ENetEvent *ev )
-//{ 
-  //printf( "A packet of length %u containing %s was "
-      //"received from %s on channel %u.\n",
-      //ev->packet->dataLength,
-      //ev->packet->data,
-      //addr,
-      //ev->channelID );
-  //return 0;
-//}
-
-//[> small testing implementation <]
-//int
-//main( int argc, char *argv[] )
-//{
-  //[> setup object and connect <]
-  //MasterServerComm msc = MasterServerComm();
-  //if( msc.connect( argv[1], 1234 ) )
-    //exit(EXIT_FAILURE);
-  
-  //[> send some data and poll for replies <]
-  //char *theinput = (char *)calloc( 100,1 );
-  //while( true )
-  //{ 
-    //fgets( theinput, 90, stdin );
-    //if( !strncmp( theinput, "quit", 4 ) )
-      //break;
-
-    //msc.sendRequest( theinput );
-    //msc.pollForReply( &callb );
-  //}
-
-//}
-*/

code/branches/presentation/src/libraries/network/MasterServerComm.h

@@ -81 +81 @@
        * 
        * Poll the master server for new data and act accordingly */
-      int pollForReply( int (*callback)( char*, ENetEvent* ) );
+      int pollForReply( int (*callback)( char*, ENetEvent* ), int delayms );
 
     private:

code/branches/presentation/src/libraries/network/MasterServerProtocol.h

@@ -33 +33 @@
 #define MS_ADDRESS "129.132.3.8"
 
+
+/*** CLIENT COMMUNICATIONS ***/
 /* Client token (shows that the party sending data is a client */
 #define MSPROTO_CLIENT "CL"
@@ -44 +46 @@
 
 
+/*** GAME SERVER COMMUNICATIONS ***/
 /* Game server token (shows that the party sending data is a game server) */
 #define MSPROTO_GAME_SERVER "GS"
@@ -62 +65 @@
 #define MSPROTO_SERVERLIST_END_LEN 6
 
+/* ping request from server */
+#define MSPROTO_PING_GAMESERVER "PING"
+#define MSPROTO_PING_GAMESERVER_LEN 4 
+
+/* ping reply */
+#define MSPROTO_ACK "ACK"
+#define MSPROTO_ACK_LEN 3 
+
 
 

code/branches/presentation/src/libraries/network/Server.cc

@@ -134 +134 @@
 
     /* make discoverable on WAN */
+    /* TODO this needs to be optional, we need a switch from the UI to
+     * enable/disable this 
+     */
     helper_ConnectToMasterserver();
 
@@ -169 +172 @@
 
 
-  /* TODO */
+  /* handle incoming data */
   int rephandler( char *addr, ENetEvent *ev )
   { 
-    /* handle incoming data */
-    /* TODO this is to be implemented. */
+    /* reply to pings */
+    if( !strncmp( (char *)ev->packet->data, MSPROTO_PING_GAMESERVER, 
+      MSPROTO_PING_GAMESERVER_LEN ) )
+      //this->msc.sendRequest( MSPROTO_ACK );
+      /* NOTE implement this after pollForReply
+       * reimplementation 
+       */
+      return 0;
 
     /* done handling, return all ok code 0 */
@@ -184 +193 @@
      * has to be done or changed.
      */
-    this->msc.pollForReply( rephandler ); 
+    this->msc.pollForReply( rephandler, 10 ); 
   }
 

code/branches/presentation/src/libraries/network/WANDiscovery.cc

@@ -133 +133 @@
     {
       /* poll for reply and act according to what was received */
-      switch( this->msc.pollForReply( rhandler ) )
+      switch( this->msc.pollForReply( rhandler, 1000 ) )
       { case 0: /* no event occured, decrease timeout */
           --i; break;