Changeset 9540

Timestamp:

Mar 10, 2013, 11:29:44 AM (12 years ago)

Author:

landauf

Message:

some refactoring in OutputManager - for unittests it is sometimes necessary to create a new instance of OutputManager (or a mock), hence we should avoid storing dead references

Location:

code/branches/testing

Files:

• src/libraries/util/output/LogWriter.cc (modified) (1 diff)
• src/libraries/util/output/OutputDefinitions.h (modified) (1 diff)
• src/libraries/util/output/OutputManager.cc (modified) (3 diffs)
• src/libraries/util/output/OutputManager.h (modified) (2 diffs)
• test/util/output/ConsoleWriterTest.cc (modified) (1 diff)

code/branches/testing/src/libraries/util/output/LogWriter.cc

@@ -118 +118 @@
 
         // request old output from MemoryWriter
-        OutputManager::getInstance().getMemoryWriter().resendOutput(this);
+        if (&OutputManager::getInstance().getMemoryWriter())
+            OutputManager::getInstance().getMemoryWriter().resendOutput(this);
     }
 

code/branches/testing/src/libraries/util/output/OutputDefinitions.h

@@ -48 +48 @@
 */
 #define REGISTER_OUTPUT_CONTEXT(name) \
-    const OutputContextContainer& name() { static const OutputContextContainer& context = registerContext(#name); return context; }
+    const OutputContextContainer& name() { static OutputContextContainer context = registerContext(#name); return context; }
 
 /**

code/branches/testing/src/libraries/util/output/OutputManager.cc

@@ -55 +55 @@
 
         this->subcontextCounter_ = 0;
+
+        this->isInitialized_ = false;
+        this->memoryWriterInstance_ = 0;
+        this->consoleWriterInstance_ = 0;
+        this->logWriterInstance_ = 0;
     }
 
@@ -62 +67 @@
     OutputManager::~OutputManager()
     {
+        while (!this->listeners_.empty())
+            this->unregisterListener(this->listeners_[0]);
+
+        if (this->memoryWriterInstance_)
+            delete this->memoryWriterInstance_;
+        if (this->consoleWriterInstance_)
+            delete this->consoleWriterInstance_;
+        if (this->logWriterInstance_)
+            delete this->logWriterInstance_;
     }
 
@@ -88 +102 @@
     /*static*/ OutputManager& OutputManager::getInstanceAndCreateListeners()
     {
-        static OutputManager& instance = OutputManager::getInstance();
-
-        static MemoryWriter& memoryWriterInstance = OutputManager::getInstance().getMemoryWriter(); (void)memoryWriterInstance;
-        static ConsoleWriter& consoleWriterInstance = OutputManager::getInstance().getConsoleWriter(); (void)consoleWriterInstance;
-        static LogWriter& logWriterInstance = OutputManager::getInstance().getLogWriter(); (void)logWriterInstance;
-
-        return instance;
-    }
-
-    /**
-     * @brief Returns the main instance of MemoryWriter which is managed by the OutputManager singleton.
-     * @note If OutputManager is ever un-singletonized, this instance must not remain static.
-     */
-    MemoryWriter& OutputManager::getMemoryWriter()
-    {
-        static MemoryWriter instance;
-        return instance;
-    }
-
-    /**
-     * @brief Returns the main instance of ConsoleWriter which is managed by the OutputManager singleton.
-     * @note If OutputManager is ever un-singletonized, this instance must not remain static.
-     */
-    ConsoleWriter& OutputManager::getConsoleWriter()
-    {
-        static ConsoleWriter instance(std::cout);
-        return instance;
-    }
-
-    /**
-     * @brief Returns the main instance of LogWriter which is managed by the OutputManager singleton.
-     * @note If OutputManager is ever un-singletonized, this instance must not remain static.
-     */
-    LogWriter& OutputManager::getLogWriter()
-    {
-        static LogWriter instance;
+        OutputManager& instance = *OutputManager::Testing::getInstancePointer();
+
+        if (!instance.isInitialized_) {
+            instance.isInitialized_ = true;
+            instance.memoryWriterInstance_ = new MemoryWriter();
+            instance.consoleWriterInstance_ = new ConsoleWriter(std::cout);
+            instance.logWriterInstance_ = new LogWriter();
+        }
+
         return instance;
     }

code/branches/testing/src/libraries/util/output/OutputManager.h

@@ -72 +72 @@
             static OutputManager& getInstanceAndCreateListeners();
 
-            MemoryWriter& getMemoryWriter();
-            ConsoleWriter& getConsoleWriter();
-            LogWriter& getLogWriter();
+            inline MemoryWriter& getMemoryWriter()   { return *this->memoryWriterInstance_; }
+            inline ConsoleWriter& getConsoleWriter() { return *this->consoleWriterInstance_; }
+            inline LogWriter& getLogWriter()         { return *this->logWriterInstance_; }
 
-            void pushMessage(OutputLevel level, const OutputContextContainer& context, const std::string& message);
+            virtual void pushMessage(OutputLevel level, const OutputContextContainer& context, const std::string& message);
 
             virtual void registerListener(OutputListener* listener);
@@ -125 +125 @@
             OutputContextSubID subcontextCounter_;                              ///< Counts the number of sub-contexts (and generates their IDs)
 
+            bool isInitialized_;                                                ///< Becomes true once the following instances were created
+            MemoryWriter*  memoryWriterInstance_;                               ///< The main instance of MemoryWriter, managed by OutputManager
+            ConsoleWriter* consoleWriterInstance_;                              ///< The main instance of ConsoleWriter, managed by OutputManager
+            LogWriter*     logWriterInstance_;                                  ///< The main instance of LogWriter, managed by OutputManager
+
         public:
             struct _UtilExport Testing

code/branches/testing/test/util/output/ConsoleWriterTest.cc

@@ -65 +65 @@
     TEST(ConsoleWriterTest, DefaultConsoleWriterUsesCout)
     {
+        OutputManager::getInstanceAndCreateListeners();
         EXPECT_EQ(std::cout, OutputManager::getInstance().getConsoleWriter().getOutputStream());
     }