Changeset 9641

Timestamp:

Aug 11, 2013, 9:33:11 PM (11 years ago)

Author:

landauf

Message:

removed mutual friend declarations between Identifier and IdentifierManager

Location:

code/branches/core6/src/libraries/core/class

Files:

• Identifier.cc (modified) (3 diffs)
• Identifier.h (modified) (2 diffs)
• IdentifierManager.cc (modified) (1 diff)
• IdentifierManager.h (modified) (3 diffs)

code/branches/core6/src/libraries/core/class/Identifier.cc

@@ -50 +50 @@
     */
     Identifier::Identifier()
-        : classID_(IdentifierManager::getInstance().classIDCounter_s++)
+        : classID_(IdentifierManager::getInstance().getUniqueClassId())
     {
         this->bCreatedOneObject_ = false;
@@ -155 +155 @@
             this->name_ = name;
             this->bSetName_ = true;
-            IdentifierManager::getInstance().identifierByString_[name] = this;
-            IdentifierManager::getInstance().identifierByLowercaseString_[getLowercase(name)] = this;
-            IdentifierManager::getInstance().identifierByNetworkId_[this->networkID_] = this;
+            IdentifierManager::getInstance().registerIdentifier(this);
         }
     }
@@ -195 +193 @@
     void Identifier::setNetworkID(uint32_t id)
     {
-//        Identifier::getIDIdentifierMapIntern().erase(this->networkID_);
-        IdentifierManager::getInstance().identifierByNetworkId_[id] = this;
         this->networkID_ = id;
+        IdentifierManager::getInstance().registerIdentifier(this);
     }
 

code/branches/core6/src/libraries/core/class/Identifier.h

@@ -106 +106 @@
     class _CoreExport Identifier
     {
-        friend class IdentifierManager;
-
         public:
+            Identifier();
+            Identifier(const Identifier& identifier); // don't copy
+            virtual ~Identifier();
+
             /// Returns the name of the class the Identifier belongs to.
             inline const std::string& getName() const { return this->name_; }
@@ -209 +211 @@
 
         protected:
-            Identifier();
-            Identifier(const Identifier& identifier); // don't copy
-            virtual ~Identifier();
-
             virtual void createSuperFunctionCaller() const = 0;
 

code/branches/core6/src/libraries/core/class/IdentifierManager.cc

@@ -77 +77 @@
             return proposal;
         }
+    }
+
+    /**
+     * Registers the identifier in all maps of the IdentifierManager.
+     */
+    void IdentifierManager::registerIdentifier(Identifier* identifier)
+    {
+        IdentifierManager::getInstance().identifierByString_[identifier->getName()] = identifier;
+        IdentifierManager::getInstance().identifierByLowercaseString_[getLowercase(identifier->getName())] = identifier;
+        IdentifierManager::getInstance().identifierByNetworkId_[identifier->getNetworkID()] = identifier;
     }
 

code/branches/core6/src/libraries/core/class/IdentifierManager.h

@@ -44 +44 @@
     class _CoreExport IdentifierManager
     {
-        friend class Identifier;
-        template <class T> friend class ClassIdentifier;
-
         public:
             static IdentifierManager& getInstance();
@@ -53 +50 @@
             ////// Class Hierarchy //////
             /////////////////////////////
+            Identifier* getIdentifierSingleton(const std::string& name, Identifier* proposal);
+
+            unsigned int getUniqueClassId()
+                { return this->classIDCounter_s++; }
+
+            void registerIdentifier(Identifier* identifier);
+
             void createClassHierarchy();
 
@@ -101 +105 @@
                 { return this->identifierByNetworkId_.end(); }
 
-        protected:
-            Identifier* getIdentifierSingleton(const std::string& name, Identifier* proposal);
-
         private:
             IdentifierManager();