Changeset 9675 in orxonox.OLD for trunk/src/lib/util

Timestamp:

Aug 21, 2006, 10:57:35 PM (18 years ago)

Author:

bensch

Message:

orxonox/trunk: more Implementation of Functionality.
Introduced map for fast search of ID/Name pairs.
This will also be used to speedup the Factory create-process

File:

• trunk/src/lib/util/loading/factory.cc (modified) (6 diffs)

trunk/src/lib/util/loading/factory.cc

@@ -29 +29 @@
  */
 Factory::Factory (const std::string& factoryName, ClassID classID)
-  : classID(classID), className(factoryName)
+    : classID(classID), className(factoryName)
 {
   this->setClassID(CL_FACTORY, "Factory");
@@ -86 +86 @@
 bool Factory::operator==(const char* className) const
 {
-  return(className != NULL && this->className == className);
+  return (className != NULL && this->className == className);
 }
 
@@ -96 +96 @@
 bool Factory::operator==(const std::string& className) const
 {
-  return(this->className == className);
+  return (this->className == className);
 }
 
@@ -105 +105 @@
  * @returns a new Object of Type root->Value() on match, NULL otherwise
  */
- BaseObject* Factory::fabricate(const TiXmlElement* root)
+BaseObject* Factory::fabricate(const TiXmlElement* root)
 {
-  if (root == NULL || Factory::factoryList == NULL)
-    return NULL;
+  assert (root != NULL && Factory::factoryList != NULL);
 
   std::list<Factory*>::const_iterator factory;
   for (factory = Factory::factoryList->begin(); factory != Factory::factoryList->end(); factory++)
     if (*(*factory) == root->Value())
-      break;
+    {
+      PRINTF(2)("Create a new Object of type %s\n", (*factory)->getCName());
+      return (*factory)->fabricateObject(root);
+    }
 
-  if (factory != Factory::factoryList->end())
-  {
-    PRINTF(2)("Create a new Object of type %s\n", (*factory)->getCName());
-    return (*factory)->fabricateObject(root);
-  }
-  else
-  {
-    PRINTF(2)("Could not Fabricate an Object of Class '%s'\n", root->Value());
-    return NULL;
-  }
+  PRINTF(2)("Could not Fabricate an Object of Class '%s'\n", root->Value());
+  return NULL;
 }
 
 
 /**
- * Creates a new Object of type className
+ * @brief Creates a new Object of type className
  * @param className the ClassName to match for the newly created Object
  * @returns a new Object of Type className on match, NULL otherwise
  */
- BaseObject* Factory::fabricate(const std::string& className)
+BaseObject* Factory::fabricate(const std::string& className)
 {
   if (Factory::factoryList == NULL)
@@ -141 +135 @@
   for (factory = Factory::factoryList->begin(); factory != Factory::factoryList->end(); factory++)
     if (*(*factory) == className)
-      break;
-
-  if (factory != Factory::factoryList->end())
-  {
-    PRINTF(4)("Create a new Object of type %s\n", (*factory)->getCName());
-    return (*factory)->fabricateObject(NULL);
-  }
-  else
-  {
-    PRINTF(2)("Could not Fabricate an Object of Class '%s'\n", className.c_str());
-    return NULL;
-  }
+    {
+      PRINTF(4)("Create a new Object of type %s\n", (*factory)->getCName());
+      return (*factory)->fabricateObject(NULL);
+    }
+  PRINTF(2)("Could not Fabricate an Object of Class '%s'\n", className.c_str());
+  return NULL;
 }
 
 
 /**
- * Creates a new Object of type classID
+ * @brief Creates a new Object of type classID
  * @param classID the ClassID to match for the newly created Object
  * @returns a new Object of Type classID on match, NULL otherwise
@@ -169 +157 @@
   for (factory = Factory::factoryList->begin(); factory != Factory::factoryList->end(); factory++)
     if (*(*factory) == classID)
-      break;
+    {
+      PRINTF(4)("Create a new Object of type %s\n", (*factory)->getCName());
+      return (*factory)->fabricateObject(NULL);
 
-  if (factory != Factory::factoryList->end())
-  {
-    PRINTF(4)("Create a new Object of type %s\n", (*factory)->getCName());
-    return (*factory)->fabricateObject(NULL);
-  }
-  else
-  {
-    PRINTF(2)("Could not Fabricate an Object of ClassID '0x%h'\n", classID);
-    return NULL;
-  }
+    }
+  PRINTF(2)("Could not Fabricate an Object of ClassID '0x%h'\n", classID);
+  return NULL;
 }