Changeset 9676 for code/trunk/src/libraries

Timestamp:

Sep 29, 2013, 4:27:05 PM (11 years ago)

Author:

landauf

Message:

fixed warnings with gcc 4.7

Location:

code/trunk/src/libraries/core/command

Files:

• IOConsoleWindows.cc (modified) (6 diffs)
• IOConsoleWindows.h (modified) (1 diff)

code/trunk/src/libraries/core/command/IOConsoleWindows.cc

@@ -102 +102 @@
 
         // Erase input and status lines
-        COORD pos = {0, this->inputLineRow_};
+        COORD pos = makeCOORD(0, this->inputLineRow_);
         this->writeText(std::string((this->inputLineHeight_ + this->statusLines_) * this->terminalWidth_, ' '), pos);
         // Move cursor to the beginning of the line
@@ -297 +297 @@
         {
             // Scroll input and status lines down
-            SMALL_RECT oldRect = {0, this->inputLineRow_,
-                this->terminalWidth_ - 1, this->inputLineRow_ + this->inputLineHeight_ + this->statusLines_ - 1};
+            SMALL_RECT oldRect = makeSMALL_RECT(0, this->inputLineRow_,
+                this->terminalWidth_ - 1, this->inputLineRow_ + this->inputLineHeight_ + this->statusLines_ - 1);
             this->inputLineRow_ += linesDown;
             ScrollConsoleScreenBuffer(stdOutHandle_, &oldRect, NULL, makeCOORD(0, this->inputLineRow_), &fillChar);
             // Move cursor down to the new bottom so the user can see the status lines
-            COORD pos = {0, this->inputLineRow_ + this->inputLineHeight_ - 1 + this->statusLines_};
+            COORD pos = makeCOORD(0, this->inputLineRow_ + this->inputLineHeight_ - 1 + this->statusLines_);
             SetConsoleCursorPosition(stdOutHandle_, pos);
             // Get cursor back to the right position
@@ -311 +311 @@
         {
             // Scroll output up
-            SMALL_RECT oldRect = {0, lines - linesDown, this->terminalWidth_ - 1, this->inputLineRow_ - 1};
+            SMALL_RECT oldRect = makeSMALL_RECT(0, lines - linesDown, this->terminalWidth_ - 1, this->inputLineRow_ - 1);
             ScrollConsoleScreenBuffer(stdOutHandle_, &oldRect, NULL, makeCOORD(0, 0), &fillChar);
         }
@@ -358 +358 @@
             // Scroll status lines up
             int statusLineRow = this->inputLineRow_ + this->inputLineHeight_;
-            SMALL_RECT oldRect = {0, statusLineRow, this->terminalWidth_ - 1, statusLineRow + this->statusLines_};
+            SMALL_RECT oldRect = makeSMALL_RECT(0, statusLineRow, this->terminalWidth_ - 1, statusLineRow + this->statusLines_);
             CHAR_INFO fillChar = {{' '}, FOREGROUND_BLUE | FOREGROUND_GREEN | FOREGROUND_RED};
             ScrollConsoleScreenBuffer(stdOutHandle_, &oldRect, NULL, makeCOORD(0, statusLineRow + newLines), &fillChar);
@@ -364 +364 @@
             if (-newLines - this->statusLines_ > 0)
             {
-                COORD pos = {0, this->inputLineRow_ + newInputLineHeight + this->statusLines_};
+                COORD pos = makeCOORD(0, this->inputLineRow_ + newInputLineHeight + this->statusLines_);
                 this->writeText(std::string((-newLines - this->statusLines_) * this->terminalWidth_, ' '), pos);
             }
@@ -398 +398 @@
         this->createNewOutputLines(this->lastOutputLineHeight_);
         // Write the text
-        COORD pos = {0, this->inputLineRow_ - this->lastOutputLineHeight_};
+        COORD pos = makeCOORD(0, this->inputLineRow_ - this->lastOutputLineHeight_);
         this->printOutputLine(it->first, it->second, pos);
     }

code/trunk/src/libraries/core/command/IOConsoleWindows.h

@@ -80 +80 @@
         void printOutputLine(const std::string& line, Shell::LineType type, const COORD& pos);
 
-        static inline COORD makeCOORD(int x, int y)
+        static inline COORD makeCOORD(SHORT x, SHORT y)
         {
             COORD val = {x, y};
+            return val;
+        }
+
+        static inline SMALL_RECT makeSMALL_RECT(SHORT left, SHORT top, SHORT right, SHORT bottom)
+        {
+            SMALL_RECT val = {left, top, right, bottom};
             return val;
         }