Changeset 8006 for code/branches/usability

Timestamp:

Mar 1, 2011, 5:16:52 AM (14 years ago)

Author:

rgrieder

Message:

Reverted last commit (forgot to tick "Switch working copy to new branch"…)

Location:

code/branches/usability

Files:

• . (modified) (1 prop)
• src/orxonox/MoodManager.h (modified) (1 diff)
• src/orxonox/sound/AmbientSound.cc (modified) (7 diffs)
• src/orxonox/sound/AmbientSound.h (modified) (5 diffs)
• src/orxonox/sound/BaseSound.cc (modified) (8 diffs)
• src/orxonox/sound/BaseSound.h (modified) (2 diffs)
• src/orxonox/sound/SoundBuffer.h (modified) (1 diff)
• src/orxonox/sound/SoundManager.cc (modified) (13 diffs)
• src/orxonox/sound/SoundManager.h (modified) (3 diffs)
• src/orxonox/sound/SoundPrereqs.h (deleted)
• src/orxonox/sound/SoundStreamer.cc (modified) (4 diffs)
• src/orxonox/sound/SoundStreamer.h (modified) (2 diffs)
• src/orxonox/sound/WorldSound.h (modified) (1 diff)
• src/orxonox/weaponsystem/WeaponMode.cc (modified) (1 diff)
• src/orxonox/weaponsystem/WeaponMode.h (modified) (2 diffs)

code/branches/usability/src/orxonox/MoodManager.h

@@ -59 +59 @@
     };
 
-    /**
-     * The MoodManager class enables the game to set different themes, i.e. audio themes, each
-     * with a set of different audio files. A theme (called mood) is set by the server and applies to
-     * all clients. Existing moods are currently hard-coded in function checkMoodValidity(). Each mood
-     * needs to have a folder with its name in "data_extern/audo/ambient/" containing sound files named like
-     * the ones in mood "default".
-     */
+    /*
+    @brief
+        The MoodManager class serves to allow for different musical themes in the game.
+    */
     class _OrxonoxExport MoodManager : public Singleton<MoodManager>, public OrxonoxClass
     {

code/branches/usability/src/orxonox/sound/AmbientSound.cc

@@ -23 +23 @@
  *      Reto Grieder
  *   Co-authors:
- *      Kevin Young
+ *      ...
  *
  */
@@ -33 +33 @@
 #include "core/Resource.h"
 #include "SoundManager.h"
-#include "SoundStreamer.h"
-#include "util/Sleep.h"
-
-#include <AL/alut.h>
 
 namespace orxonox
 {
-    // vorbis callbacks
-    size_t readVorbis(void* ptr, size_t size, size_t nmemb, void* datasource);
-    int seekVorbis(void* datasource, ogg_int64_t offset, int whence);
-    long tellVorbis(void* datasource);
-    
     AmbientSound::AmbientSound()
         : bPlayOnLoad_(false)
@@ -51 +42 @@
 
         // Ambient sounds always fade in
-        //this->setVolume(0);
+        this->setVolume(0);
     }
 
@@ -60 +51 @@
             // Smoothly fade out by keeping a SmartPtr
             SoundManager::getInstance().unregisterAmbientSound(this);
-            this->soundstreamthread_.interrupt();
         }
     }
@@ -72 +62 @@
     bool AmbientSound::stop()
     {
-        if (GameMode::playsSound()) 
+        if (GameMode::playsSound())
             SoundManager::getInstance().unregisterAmbientSound(this);
         return false; // sound source not (yet) destroyed - return false
@@ -102 +92 @@
             shared_ptr<ResourceInfo> fileInfo = Resource::getInfo(path);
             if (fileInfo != NULL)
-                this->setStreamSource(path);
+                this->setSource(path);
             else
                 COUT(3) << "Sound: " << this->ambientSource_ << ": Not a valid name! Ambient sound will not change." << std::endl;
@@ -114 +104 @@
             this->play();
     }
-
-    // hacky solution for file streaming
-    void AmbientSound::setStreamSource(const std::string& source)
-    {
-        if (!GameMode::playsSound())
-        {
-            this->source_ = source;
-            return;
-        }
-
-        if(!alIsSource(this->audioSource_))
-            this->audioSource_ = SoundManager::getInstance().getSoundSource(this);
-
-        if (this->source_ == source)
-        {
-            return;
-        }
-
-        this->source_ = source;
-        // Don't load ""
-        if (source_.empty())
-            return;
-
-        if (this->soundstreamthread_.get_id() != boost::thread::id())
-        {
-            this->soundstreamthread_.interrupt(); // terminate an old thread if necessary
-        }
-
-        // queue some init buffers
-        COUT(4) << "Sound: Creating thread for " << source << std::endl;
-        // Get resource info
-        shared_ptr<ResourceInfo> fileInfo = Resource::getInfo(source);
-        if (fileInfo == NULL)
-        {
-            COUT(2) << "Sound: Warning: Sound file '" << source << "' not found" << std::endl;
-            return;
-        }
-        // Open data stream
-        DataStreamPtr dataStream = Resource::open(fileInfo);
-        
-        alSourcei(this->audioSource_, AL_BUFFER, 0);
-
-        // Open file with custom streaming
-        ov_callbacks vorbisCallbacks;
-        vorbisCallbacks.read_func  = &readVorbis;
-        vorbisCallbacks.seek_func  = &seekVorbis;
-        vorbisCallbacks.tell_func  = &tellVorbis;
-        vorbisCallbacks.close_func = NULL;
-
-        OggVorbis_File* vf = new OggVorbis_File();
-        int ret = ov_open_callbacks(dataStream.get(), vf, NULL, 0, vorbisCallbacks);
-        if (ret < 0)
-        {
-            COUT(2) << "Sound: libvorbisfile: File does not seem to be an Ogg Vorbis bitstream" << std::endl;
-            ov_clear(vf);
-            return;
-        }
-        vorbis_info* vorbisInfo;
-        vorbisInfo = ov_info(vf, -1);
-        ALenum format;
-        if (vorbisInfo->channels == 1)
-            format = AL_FORMAT_MONO16;
-        else
-            format = AL_FORMAT_STEREO16;
-
-        char inbuffer[4096];
-        ALuint initbuffers[10];
-        alGenBuffers(10, initbuffers);
-        if (ALint error = alGetError()) {
-            COUT(2) << "Sound: Streamer: Could not generate buffer:" << getALErrorString(error) << std::endl;
-            return;
-        }
-        int current_section;
-
-        for(int i = 0; i < 10; i++)
-        {
-            long ret = ov_read(vf, inbuffer, sizeof(inbuffer), 0, 2, 1, &current_section);
-            if (ret == 0)
-            {
-                break;
-            }
-            else if (ret < 0)
-            {
-                COUT(2) << "Sound: libvorbisfile: error reading the file" << std::endl;
-                ov_clear(vf);
-                return;
-            }
-
-            alBufferData(initbuffers[i], format, &inbuffer, ret, vorbisInfo->rate);
-            if(ALint error = alGetError()) {
-                COUT(2) << "Sound: Could not fill buffer: " << getALErrorString(error) << std::endl;
-                break;
-             }
-             alSourceQueueBuffers(this->audioSource_, 1, &initbuffers[i]);
-             if (ALint error = alGetError()) {
-                 COUT(2) << "Sound: Warning: Couldn't queue buffers: " << getALErrorString(error) << std::endl;
-             }
-        }
-        
-        this->soundstreamthread_ = boost::thread(SoundStreamer(), this->audioSource_, dataStream, vf, current_section);
-        if(this->soundstreamthread_ == boost::thread())
-            COUT(2) << "Sound: Failed to create thread." << std::endl;
-        //SoundStreamer streamer;
-        //streamer(this->audioSource_, dataStream);
-
-        alSource3f(this->audioSource_, AL_POSITION,  0, 0, 0);
-        alSource3f(this->audioSource_, AL_VELOCITY,  0, 0, 0);
-        alSource3f(this->audioSource_, AL_DIRECTION, 0, 0, 0);
-        if (ALint error = alGetError())
-            COUT(2) << "Sound: Warning: Setting source parameters to 0 failed: " << getALErrorString(error) << std::endl;
-    }
-
-    bool AmbientSound::doStop()
-    {
-        bool result = BaseSound::doStop();
-        this->soundstreamthread_.interrupt();
-        return result;
-    }
-
-    void AmbientSound::doPlay()
-    {
-        BaseSound::doPlay();
-
-        if(GameMode::playsSound() && this->getSourceState() != AL_PLAYING)
-        {
-            if(!alIsSource(this->audioSource_))
-            {
-                this->audioSource_ = SoundManager::getInstance().getSoundSource(this);
-                if(!alIsSource(this->audioSource_))
-                    return;
-                this->initialiseSource();
-            }
-
-            alSourcePlay(this->audioSource_);
-            if(int error = alGetError())
-                COUT(2) << "Sound: Error playing sound: " << getALErrorString(error) << std::endl;
-        }
-    }
 }

code/branches/usability/src/orxonox/sound/AmbientSound.h

@@ -22 +22 @@
  *   Author:
  *      Reto Grieder
- *      
+ *      Kevin Young
  *   Co-authors:
- *      Kevin Young
+ *      ...
  *
  */
@@ -31 +31 @@
 #define _AmbientSound_H__
 
-#include <boost/thread.hpp>
-
-#include "sound/SoundPrereqs.h"
+#include "OrxonoxPrereqs.h"
 
 #include "BaseSound.h"
@@ -41 +39 @@
 {
     /**
-     * The AmbientSound class implements the non-3D sound, i.e. sound files that are used for atmospheric
-     * highlighting.
-     * It interfaces with BaseSound and is controllable by MoodManager.
-     * Ambient sounds are always cross-faded. New sounds are registered and activated/deactivated as needed.
-     *
+     * The AmbientSound class is used to play background music. It can not be placed
+     * directly in a level file, use WorldAmbientSound instead.
      */
     class _OrxonoxExport AmbientSound : public BaseSound, public MoodListener
@@ -70 +65 @@
         ~AmbientSound() { }
 
-        bool doStop();
-        void doPlay();
-
     private:
         void preDestroy();
@@ -84 +76 @@
         std::string ambientSource_; //!< Analogous to source_, but mood independent
         bool        bPlayOnLoad_;   //!< Play the sound immediately when loaded
-
-        boost::thread soundstreamthread_; // hacky solution for streaming
-        void setStreamSource(const std::string& source);
     };
 }

code/branches/usability/src/orxonox/sound/BaseSound.cc

@@ -92 +92 @@
             alSourcePlay(this->audioSource_);
             if (int error = alGetError())
-                COUT(2) << "Sound: Error playing sound: " << getALErrorString(error) << std::endl;
+                COUT(2) << "Sound: Error playing sound: " << SoundManager::getALErrorString(error) << std::endl;
         }
     }
@@ -145 +145 @@
         alSource3f(this->audioSource_, AL_DIRECTION, 0, 0, 0);
         if (ALint error = alGetError())
-            COUT(2) << "Sound: Warning: Setting source parameters to 0 failed: " << getALErrorString(error) << std::endl;
-        if(this->soundBuffer_ != NULL) {
-            alSourcei(this->audioSource_, AL_BUFFER, this->soundBuffer_->getBuffer());
-        }
+            COUT(2) << "Sound Warning: Setting source parameters to 0 failed: "
+                    << SoundManager::getALErrorString(error) << std::endl;
+        assert(this->soundBuffer_ != NULL);
+        alSourcei(this->audioSource_, AL_BUFFER, this->soundBuffer_->getBuffer());
         if (ALuint error = alGetError())
-            COUT(1) << "Sound: Error: Could not set buffer \"" << this->source_ << "\": " << getALErrorString(error) << std::endl;
+            COUT(1) << "Sound Error: Could not set buffer \"" << this->source_ << "\": " << SoundManager::getALErrorString(error) << std::endl;
     }
 
@@ -157 +157 @@
         this->volume_ = clamp(vol, 0.0f, 1.0f);
         if (this->volume_ != vol)
-            COUT(2) << "Sound: Warning: volume out of range, clamping value." << std::endl;
+            COUT(2) << "Sound warning: volume out of range, clamping value." << std::endl;
         this->updateVolume();
     }
@@ -168 +168 @@
             alSourcef(this->audioSource_, AL_GAIN, volume);
             if (int error = alGetError())
-                COUT(2) << "Sound: Error setting volume to " << volume << ": " << getALErrorString(error) << std::endl;
+                COUT(2) << "Sound: Error setting volume to " << volume
+                        << ": " << SoundManager::getALErrorString(error) << std::endl;
         }
     }
@@ -183 +184 @@
         if (pitch > 2 || pitch < 0.5f)
         {
-            COUT(2) << "Sound: Warning: pitch out of range, cropping value." << std::endl;
+            COUT(2) << "Sound warning: pitch out of range, cropping value." << std::endl;
             pitch = pitch > 2.0f ? 2.0f : pitch;
             pitch = pitch < 0.5f ? 0.5f : pitch;
@@ -192 +193 @@
             alSourcef(this->audioSource_, AL_PITCH, pitch);
             if (int error = alGetError())
-                COUT(2) << "Sound: Error setting pitch: " << getALErrorString(error) << std::endl;
+                COUT(2) << "Sound: Error setting pitch: " << SoundManager::getALErrorString(error) << std::endl;
         }
     }
@@ -237 +238 @@
             if (ALuint error = alGetError())
             {
-                COUT(1) << "Sound: Error: Could not set buffer \"" << source << "\": " << getALErrorString(error) << std::endl;
+                COUT(1) << "Sound Error: Could not set buffer \"" << source << "\": " << SoundManager::getALErrorString(error) << std::endl;
                 return;
             }
@@ -245 +246 @@
             alSourcePlay(this->audioSource_);
             if (int error = alGetError())
-                COUT(2) << "Sound: Error playing sound: " << getALErrorString(error) << std::endl;
+                COUT(2) << "Sound: Error playing sound: " << SoundManager::getALErrorString(error) << std::endl;
             if (this->isPaused())
                 alSourcePause(this->audioSource_);

code/branches/usability/src/orxonox/sound/BaseSound.h

@@ -30 +30 @@
 #define _BaseSound_H__
 
-#include "sound/SoundPrereqs.h"
+#include "OrxonoxPrereqs.h"
 
 #include <string>
@@ -85 +85 @@
         virtual ~BaseSound();
 
-        virtual void doPlay();
-        virtual bool doStop(); // returns true if the sound source was destroyed
-        virtual void doPause();
+        void doPlay();
+        bool doStop(); // returns true if the sound source was destroyed
+        void doPause();
 
         // network callbacks

code/branches/usability/src/orxonox/sound/SoundBuffer.h

@@ -30 +30 @@
 #define _SoundBuffer_H__
 
-#include "sound/SoundPrereqs.h"
+#include "OrxonoxPrereqs.h"
 
 #include <list>

code/branches/usability/src/orxonox/sound/SoundManager.cc

@@ -22 +22 @@
  *   Author:
  *       Erwin 'vaiursch' Herrsche
- *       
- *   Co-authors:
  *       Kevin Young
  *       Reto Grieder
+ *   Co-authors:
+ *      ...
  *
  */
@@ -52 +52 @@
     ManageScopedSingleton(SoundManager, ScopeID::Graphics, true);
 
-    // From SoundPrereqs.h
-    std::string getALErrorString(ALenum code)
+    std::string SoundManager::getALErrorString(ALenum code)
     {
         switch (code)
@@ -81 +80 @@
 
         if (!alutInitWithoutContext(NULL, NULL))
-            ThrowException(InitialisationFailed, "Sound: Error: ALUT initialisation failed: " << alutGetErrorString(alutGetError()));
+            ThrowException(InitialisationFailed, "Sound Error: ALUT initialisation failed: " << alutGetErrorString(alutGetError()));
         Loki::ScopeGuard alutExitGuard = Loki::MakeGuard(&alutExit);
 
@@ -113 +112 @@
             COUT(1) << "Sound: Just getting the DLL with the dependencies is not enough for Windows (esp. Windows 7)!" << std::endl;
 #endif
-            ThrowException(InitialisationFailed, "Sound: Error: Could not open sound device.");
+            ThrowException(InitialisationFailed, "Sound Error: Could not open sound device.");
         }
         Loki::ScopeGuard closeDeviceGuard = Loki::MakeGuard(&alcCloseDevice, this->device_);
 
         // Create sound context and make it the currently used one
-        const ALint contattr[]  = {ALC_SYNC, 1, 0};
-        this->context_ = alcCreateContext(this->device_, contattr);
+        this->context_ = alcCreateContext(this->device_, NULL);
         if (this->context_ == NULL)
-            ThrowException(InitialisationFailed, "Sound: Error: Could not create ALC context");
+            ThrowException(InitialisationFailed, "Sound Error: Could not create ALC context");
         Loki::ScopeGuard desroyContextGuard = Loki::MakeGuard(&alcDestroyContext, this->context_);
         if (!alcMakeContextCurrent(this->context_))
-            ThrowException(InitialisationFailed, "Sound: Error: Could not use ALC context");
+            ThrowException(InitialisationFailed, "Sound Error: Could not use ALC context");
 
         GameMode::setPlaysSound(true);
@@ -137 +135 @@
             COUT(4) << "Sound: --- Supported MIME Types: " << types << std::endl;
         else
-            COUT(2) << "Sound: Warning: MIME Type retrieval failed: " << alutGetErrorString(alutGetError()) << std::endl;
+            COUT(2) << "Sound Warning: MIME Type retrieval failed: " << alutGetErrorString(alutGetError()) << std::endl;
 
         this->mute_[SoundType::All]     = 1.0f;
@@ -151 +149 @@
             this->availableSoundSources_.push_back(source);
         else
-            ThrowException(InitialisationFailed, "Sound: Error: Could not create even a single source");
+            ThrowException(InitialisationFailed, "Sound Error: Could not create even a single source");
         // Create a few initial sources
         this->createSoundSources(this->minSources_ - 1);
@@ -173 +171 @@
         // If there are still used buffers around, well, that's just very bad...
         if (this->soundBuffers_.size() != this->effectsPool_.size())
-            COUT(1) << "Sound: Error: Some sound buffers are still in use but OpenAL is about to shut down. Fix this!" << std::endl;
+            COUT(1) << "Sound Error: Some sound buffers are still in use but OpenAL is about to shut down. Fix this!" << std::endl;
         // Empty buffer pool and buffer list
         this->effectsPool_.clear();
@@ -180 +178 @@
         // There should not be any sources in use anymore
         if (!this->usedSoundSources_.empty())
-            COUT(1) << "Sound: Error: Some sound sources are still in use but OpenAL is about to shut down. Fix this!" << std::endl;
+            COUT(1) << "Sound Error: Some sound sources are still in use but OpenAL is about to shut down. Fix this!" << std::endl;
         while (!this->availableSoundSources_.empty())
         {
@@ -191 +189 @@
         // Relieve context to destroy it
         if (!alcMakeContextCurrent(NULL))
-            COUT(1) << "Sound: Error: Could not unset ALC context" << std::endl;
+            COUT(1) << "Sound Error: Could not unset ALC context" << std::endl;
         alcDestroyContext(this->context_);
         if (ALCenum error = alcGetError(this->device_))
         {
             if (error == AL_INVALID_OPERATION)
-                COUT(1) << "Sound: Error: Could not destroy ALC context because it is the current one" << std::endl;
+                COUT(1) << "Sound Error: Could not destroy ALC context because it is the current one" << std::endl;
             else
-                COUT(1) << "Sound: Error: Could not destroy ALC context because it is invalid" << std::endl;
+                COUT(1) << "Sound Error: Could not destroy ALC context because it is invalid" << std::endl;
         }
 #ifdef AL_VERSION_1_1
         if (!alcCloseDevice(this->device_))
-            COUT(1) << "Sound: Error: Could not destroy ALC device. This might be because there are still buffers in use!" << std::endl;
+            COUT(1) << "Sound Error: Could not destroy ALC device. This might be because there are still buffers in use!" << std::endl;
 #else
         alcCloseDevice(this->device_);
 #endif
         if (!alutExit())
-            COUT(1) << "Sound: Error: Closing ALUT failed: " << alutGetErrorString(alutGetError()) << std::endl;
+            COUT(1) << "Sound Error: Closing ALUT failed: " << alutGetErrorString(alutGetError()) << std::endl;
     }
 
@@ -253 +251 @@
         if (crossFadeStep_ <= 0.0 || crossFadeStep_ >= 1.0 )
         {
-            COUT(2) << "Sound: Warning: fade step out of range, ignoring change." << std::endl;
+            COUT(2) << "Sound warning: fade step out of range, ignoring change." << std::endl;
             ResetConfigValue(crossFadeStep_);
         }
@@ -262 +260 @@
         float clampedVolume = clamp(this->volume_[type], 0.0f, 1.0f);
         if (clampedVolume != this->volume_[type])
-            COUT(2) << "Sound: Warning: Volume setting (" << type << ") out of range, clamping." << std::endl;
+            COUT(2) << "Sound warning: Volume setting (" << type << ") out of range, clamping." << std::endl;
         this->updateVolume(type);
     }
@@ -354 +352 @@
                 if (it->first == newAmbient)
                 {
-                    COUT(2) << "Sound: Warning: Will not play an AmbientSound twice." << std::endl;
+                    COUT(2) << "Sound warning: Will not play an AmbientSound twice." << std::endl;
                     return;
                 }
@@ -622 +620 @@
             alDeleteSources(1, &this->availableSoundSources_.back());
             if (alGetError())
-                COUT(1) << "Sound: Error: Failed to delete a source --> lost forever" << std::endl;
+                COUT(1) << "Sound Error: Failed to delete a source --> lost forever" << std::endl;
             this->availableSoundSources_.pop_back();
         }

code/branches/usability/src/orxonox/sound/SoundManager.h

@@ -22 +22 @@
  *   Author:
  *       Erwin 'vaiursch' Herrsche
- *       
- *   Co-authors:
  *       Kevin Young
  *       Reto Grieder
+ *   Co-authors:
+ *      ...
  */
 
@@ -31 +31 @@
 #define _SoundManager_H__
 
-#include "sound/SoundPrereqs.h"
+#include "OrxonoxPrereqs.h"
 
 #include <list>
@@ -99 +99 @@
         void releaseSoundSource(ALuint source);
 
+        static std::string getALErrorString(ALenum error);
+
     private:
         void processCrossFading(float dt);

code/branches/usability/src/orxonox/sound/SoundStreamer.cc

@@ -27 +27 @@
 #include "SoundStreamer.h"
 
-#include <boost/thread.hpp>
-#include <AL/al.h>
-#include <AL/alc.h>
+#include <al.h>
 #include <vorbis/vorbisfile.h>
 #include "SoundManager.h"
-#include "util/Sleep.h"
 
 namespace orxonox
@@ -41 +38 @@
     long tellVorbis(void* datasource);
 
-    void orxonox::SoundStreamer::operator()(ALuint audioSource, DataStreamPtr dataStream, OggVorbis_File* vf, int current_section)
+    void orxonox::SoundStreamer::operator()(ALuint audioSource, DataStreamPtr dataStream)
     {
-        char inbuffer[4096];
+        // Open file with custom streaming
+        ov_callbacks vorbisCallbacks;
+        vorbisCallbacks.read_func  = &readVorbis;
+        vorbisCallbacks.seek_func  = &seekVorbis;
+        vorbisCallbacks.tell_func  = &tellVorbis;
+        vorbisCallbacks.close_func = NULL;
+
+        OggVorbis_File vf;
+        int ret = ov_open_callbacks(dataStream.get(), &vf, NULL, 0, vorbisCallbacks);
+        if (ret < 0)
+        {
+            COUT(2) << "Sound: libvorbisfile: File does not seem to be an Ogg Vorbis bitstream" << std::endl;
+            ov_clear(&vf);
+            return;
+        }
         vorbis_info* vorbisInfo;
-        vorbisInfo = ov_info(vf, -1);
+        vorbisInfo = ov_info(&vf, -1);
         ALenum format;
         if (vorbisInfo->channels == 1)
@@ -52 +63 @@
             format = AL_FORMAT_STEREO16;
 
-        while(true) // Stream forever, control through thread control
+        char inbuffer[256*1024];
+        ALuint initbuffers[4];
+        alGenBuffers(4, initbuffers);
+        int current_section;
+
+        for(int i = 0; i < 4; i++)
         {
-
-            int info;
-            alGetSourcei(audioSource, AL_SOURCE_STATE, &info);
-            if(info == AL_PLAYING)
-                COUT(4) << "Sound: " << dataStream->getName() << " is playing." << std::endl;
-            else
+            long ret = ov_read(&vf, inbuffer, sizeof(inbuffer), 0, 2, 1, &current_section);
+            if (ret == 0)
             {
-                COUT(4) << "Sound: " << dataStream->getName() << " is not playing." << std::endl;
+                return;
             }
-
-            if(alcGetCurrentContext() == NULL)
+            else if (ret < 0)
             {
-                COUT(2) << "Sound: There is no context, terminating thread for " << dataStream->getName() << std::endl;
+                COUT(2) << "Sound: libvorbisfile: error reading the file" << std::endl;
+                ov_clear(&vf);
                 return;
             }
 
+            alBufferData(initbuffers[i], format, &inbuffer, ret, vorbisInfo->rate);
+        }
+        alSourceQueueBuffers(audioSource, 4, initbuffers);
+
+        while(true) // Stream forever, control through thread control
+        {
             int processed;
             alGetSourcei(audioSource, AL_BUFFERS_PROCESSED, &processed);
             if (ALint error = alGetError())
-                COUT(2) << "Sound: Warning: Couldn't get number of processed buffers: " << getALErrorString(error) << std::endl;
-
-            COUT(4) << "Sound: processed buffers: " << processed << std::endl;
+            COUT(2) << "Sound Warning: Couldn't get number of processed buffers: "
+                    << SoundManager::getALErrorString(error) << std::endl;
 
             if(processed > 0)
@@ -82 +99 @@
                 alSourceUnqueueBuffers(audioSource, processed, buffers);
                 if (ALint error = alGetError())
-                    COUT(2) << "Sound: Warning: Couldn't unqueue buffers: " << getALErrorString(error) << std::endl;
-            
-                int queued;
-                alGetSourcei(audioSource, AL_BUFFERS_QUEUED, &queued);
-                if (ALint error = alGetError())
-                    COUT(2) << "Sound: Warning: Couldn't get number of queued buffers: " << getALErrorString(error) << std::endl;
-                COUT(4) << "Sound: queued buffers: " << queued << std::endl;
+                    COUT(2) << "Sound Warning: Couldn't unqueue buffers: "
+                    << SoundManager::getALErrorString(error) << std::endl;
 
                 for(int i = 0; i < processed; i++)
                 {
-                    long ret = ov_read(vf, inbuffer, sizeof(inbuffer), 0, 2, 1, &current_section);
+                    long ret = ov_read(&vf, inbuffer, sizeof(inbuffer), 0, 2, 1, &current_section);
                     if (ret == 0)
                     {
-                        COUT(4) << "Sound: End of file " << dataStream->getName() << ", terminating thread" << std::endl;
                         return;
                     }
                     else if (ret < 0)
                     {
-                        COUT(2) << "Sound: libvorbisfile: error reading the file " << dataStream->getName() << std::endl;
-                        ov_clear(vf);
+                        COUT(2) << "Sound: libvorbisfile: error reading the file" << std::endl;
+                        ov_clear(&vf);
                         return;
                     }
 
                     alBufferData(buffers[i], format, &inbuffer, ret, vorbisInfo->rate);
-                    if(ALint error = alGetError()) {
-                        COUT(2) << "Sound: Could not fill buffer: " << getALErrorString(error) << std::endl;
-                        break;
-                    }
-                    alSourceQueueBuffers(audioSource, 1, &buffers[i]);
-                    if (ALint error = alGetError()) {
-                        COUT(2) << "Sound: Warning: Couldn't queue buffers: " << getALErrorString(error) << std::endl;
-                    }
                 }
-            }
-            else
-            {
-                msleep(10); // perhaps another value here is better
-            }
 
-            try {
-                boost::this_thread::interruption_point();
-            }
-            catch(boost::thread_interrupted) {
-                COUT(4) << "Sound: Catched interruption. Terminating thread for " << dataStream->getName() << std::endl;
-                ALuint* buffers = new ALuint[5];
-                alSourceUnqueueBuffers(audioSource, 5, buffers);
+                alSourceQueueBuffers(audioSource, processed, buffers);
                 if (ALint error = alGetError())
-                    COUT(2) << "Sound: Warning: Couldn't unqueue buffers: " << getALErrorString(error) << std::endl;
-
-                alDeleteBuffers(5, buffers);
-                if (ALint error = alGetError())
-                    COUT(2) << "Sound: Warning: Couldn't delete buffers: " << getALErrorString(error) << std::endl;
-
-                return;
+                    COUT(2) << "Sound Warning: Couldn't queue buffers: "
+                    << SoundManager::getALErrorString(error) << std::endl;
             }
         }

code/branches/usability/src/orxonox/sound/SoundStreamer.h

@@ -29 +29 @@
 #define _SoundStreamer_H__
 
-#include "sound/SoundPrereqs.h"
+#include "OrxonoxPrereqs.h"
 
 #include <string>
-#include <vorbis/vorbisfile.h>
 #include <OgreDataStream.h>
 #include "core/CorePrereqs.h"
@@ -41 +40 @@
     {
     public:
-        void operator()(ALuint audioSource, DataStreamPtr dataStream, OggVorbis_File* vf, int current_section);
+        void operator()(ALuint audioSource, DataStreamPtr dataStream);
     };
 }

code/branches/usability/src/orxonox/sound/WorldSound.h

@@ -30 +30 @@
 #define _WorldSound_H__
 
-#include "sound/SoundPrereqs.h"
+#include "OrxonoxPrereqs.h"
 
 #include "tools/interfaces/Tickable.h"

code/branches/usability/src/orxonox/weaponsystem/WeaponMode.cc

@@ -24 +24 @@
  *      Fabian 'x3n' Landau
  *   Co-authors:
- *      Kevin Young
+ *      ...
  *
  */

code/branches/usability/src/orxonox/weaponsystem/WeaponMode.h

@@ -24 +24 @@
  *      Fabian 'x3n' Landau
  *   Co-authors:
- *      Kevin Young
+ *      ...
  *
  */
@@ -41 +41 @@
 namespace orxonox
 {
-    /**
-     * The WeaponMode class enables the developer, amongst other things, to attach a sound file
-     * to the firing event of a weapon. The default firing sound is chosen by each weapon (ex.
-     * HsW01), hard-coded for now.
-     */
     class _OrxonoxExport WeaponMode : public BaseObject
     {